documents: rewrite public holdings/items view in Angular #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
force-pushed
the
zub-holdings-admin
branch
2 times, most recently
from
9d62a79
to
795c385
Compare
Garfield-fr
force-pushed
the
zub-holdings-admin
branch
4 times, most recently
from
4762230
to
0fe1939
Compare
iGormilhit
added
the
f: public ui
Garfield-fr
force-pushed
the
zub-holdings-admin
branch
from
0fe1939
to
f8ec2b1
Compare
Garfield-fr
changed the title
Garfield-fr
force-pushed
the
zub-holdings-admin
branch
5 times, most recently
from
ceff6b6
to
d0b8d5a
Compare
iGormilhit
approved these changes
Jan 20, 2021
Garfield-fr
force-pushed
the
zub-holdings-admin
branch
3 times, most recently
from
7298580
to
75c1857
Compare
zannkukai
reviewed
Jan 21, 2021
zannkukai
approved these changes
Jan 21, 2021
projects/public-search/src/app/document-detail/holdings/holding/holding.component.html
Show resolved
Hide resolved
projects/public-search/src/app/document-detail/holdings/holding/holding.component.html
Outdated
Show resolved
Hide resolved
...public-search/src/app/document-detail/request/pickup-location/pickup-location.component.html
Outdated
Show resolved
Hide resolved
projects/public-search/src/app/document-detail/request/request.component.ts
Outdated
Show resolved
Hide resolved
Garfield-fr
force-pushed
the
zub-holdings-admin
branch
from
75c1857
to
fdf40ff
Compare
Garfield-fr
force-pushed
the
zub-holdings-admin
branch
2 times, most recently
from
d9a85f7
to
44359be
Compare
Garfield-fr
force-pushed
the
zub-holdings-admin
branch
from
44359be
to
32d8a4c
Compare
zannkukai
approved these changes
Feb 2, 2021
AoNoOokami
approved these changes
Feb 2, 2021
Garfield-fr
force-pushed
the
zub-holdings-admin
branch
from
32d8a4c
to
0e1ec04
Compare
* Implements the holdings section of the document detailed view of the public interface to improve the user experience when loading holdings with lots of items. With the JINJA templates, the performance is very bad. Angular allows to lazy load data and will make easier to add dynamic interaction between the user and the interface. * Adds pagination on holdings of the professional interface. * Closes rero/rero-ils#1401 * Closes rero/rero-ils#1563 * Closes rero/rero-ils#1577 Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr
force-pushed
the
zub-holdings-admin
branch
from
0e1ec04
to
48bfcfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the holdings section of the document detailed
view of the public interface to improve the user experience when
loading holdings with lots of items. With the JINJA templates, the
performance is very bad. Angular allows to lazy load data and will
make easier to add dynamic interaction between the user and the interface.
Adds pagination on holdings of the professional interface.
Closes Performance issue when loading and displaying documents with many items in the public interface rero-ils#1401, closes "Label" should be renamed into "Unit" in the professional document detailed view rero-ils#1577
Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch
Code review check list