Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display items/holdings on top according to the login library in the professional view #1563

Closed
pronguen opened this issue Dec 15, 2020 · 3 comments
Closed

Display items/holdings on top according to the login library in the professional view #1563

pronguen opened this issue Dec 15, 2020 · 3 comments
Labels
effort: important US candidate enhancement Improvement of an existing feature f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-Low Low priority wontfix This issue will not be addressed

Comments

@pronguen
Copy link
Contributor

pronguen commented Dec 15, 2020 •
edited
Loading

How it works

Currently, items and holdings are sorted according to their pid.

Improvement suggestion

In the pro interface, holdings of the librarian login library are displayed first.

Concerning the public interface, the enhancement is in #1740.
@pronguen pronguen added enhancement Improvement of an existing feature f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface triage labels Dec 15, 2020
@iGormilhit iGormilhit added needs info effort: important US candidate p-Medium Medium priority (to be solved within 1-2 years) and removed triage labels Dec 16, 2020
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jan 21, 2021
@Garfield-fr
documents: rewrite public holdings/items view in Angular
7298580 
* Implements the holdings section of the document detailed
view of the public interface to improve the user experience when
loading holdings with lots of items. With the JINJA templates, the
performance is very bad. Angular allows to lazy load data and will
make easier to add dynamic interaction between the user and the interface.
* Adds pagination on holdings of the professional interface.

* Closes rero/rero-ils#1401
* Closes rero/rero-ils#1563
* Closes rero/rero-ils#1577

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jan 21, 2021
@Garfield-fr
documents: rewrite public holdings/items view in Angular
75c1857 
* Implements the holdings section of the document detailed
view of the public interface to improve the user experience when
loading holdings with lots of items. With the JINJA templates, the
performance is very bad. Angular allows to lazy load data and will
make easier to add dynamic interaction between the user and the interface.
* Adds pagination on holdings of the professional interface.

* Closes rero/rero-ils#1401
* Closes rero/rero-ils#1563
* Closes rero/rero-ils#1577

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jan 27, 2021
@Garfield-fr
documents: rewrite public holdings/items view in Angular
fdf40ff 
* Implements the holdings section of the document detailed
view of the public interface to improve the user experience when
loading holdings with lots of items. With the JINJA templates, the
performance is very bad. Angular allows to lazy load data and will
make easier to add dynamic interaction between the user and the interface.
* Adds pagination on holdings of the professional interface.

* Closes rero/rero-ils#1401
* Closes rero/rero-ils#1563
* Closes rero/rero-ils#1577

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jan 29, 2021
@Garfield-fr
documents: rewrite public holdings/items view in Angular
d9a85f7 
* Implements the holdings section of the document detailed
view of the public interface to improve the user experience when
loading holdings with lots of items. With the JINJA templates, the
performance is very bad. Angular allows to lazy load data and will
make easier to add dynamic interaction between the user and the interface.
* Adds pagination on holdings of the professional interface.

* Closes rero/rero-ils#1401
* Closes rero/rero-ils#1563
* Closes rero/rero-ils#1577

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jan 29, 2021
@Garfield-fr
documents: rewrite public holdings/items view in Angular
44359be 
* Implements the holdings section of the document detailed
view of the public interface to improve the user experience when
loading holdings with lots of items. With the JINJA templates, the
performance is very bad. Angular allows to lazy load data and will
make easier to add dynamic interaction between the user and the interface.
* Adds pagination on holdings of the professional interface.

* Closes rero/rero-ils#1401
* Closes rero/rero-ils#1563
* Closes rero/rero-ils#1577

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@pronguen pronguen mentioned this issue Feb 1, 2021
Merged
7 tasks
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Feb 2, 2021
@Garfield-fr
documents: rewrite public holdings/items view in Angular
32d8a4c 
* Implements the holdings section of the document detailed
view of the public interface to improve the user experience when
loading holdings with lots of items. With the JINJA templates, the
performance is very bad. Angular allows to lazy load data and will
make easier to add dynamic interaction between the user and the interface.
* Adds pagination on holdings of the professional interface.

* Closes rero/rero-ils#1401
* Closes rero/rero-ils#1563
* Closes rero/rero-ils#1577

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Feb 2, 2021
@Garfield-fr
documents: rewrite public holdings/items view in Angular
0e1ec04 
* Implements the holdings section of the document detailed
view of the public interface to improve the user experience when
loading holdings with lots of items. With the JINJA templates, the
performance is very bad. Angular allows to lazy load data and will
make easier to add dynamic interaction between the user and the interface.
* Adds pagination on holdings of the professional interface.

* Closes rero/rero-ils#1401
* Closes rero/rero-ils#1563
* Closes rero/rero-ils#1577

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Feb 2, 2021
@Garfield-fr
documents: rewrite public holdings/items view in Angular
48bfcfc 
* Implements the holdings section of the document detailed
view of the public interface to improve the user experience when
loading holdings with lots of items. With the JINJA templates, the
performance is very bad. Angular allows to lazy load data and will
make easier to add dynamic interaction between the user and the interface.
* Adds pagination on holdings of the professional interface.

* Closes rero/rero-ils#1401
* Closes rero/rero-ils#1563
* Closes rero/rero-ils#1577

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@iGormilhit
Copy link

In v1.0.0 the holdings sorting is not as this issue described it.

@iGormilhit iGormilhit reopened this Feb 8, 2021
@iGormilhit iGormilhit added this to the v1.2.0 milestone Feb 8, 2021
@pronguen pronguen removed this from the v1.0.2 milestone Mar 2, 2021
@pronguen pronguen changed the title Display items/holdings on top in accordance to the user Display items/holdings on top according to the login library in the professional view Mar 2, 2021
@iGormilhit iGormilhit added this to the v1.3.0 milestone Mar 4, 2021
@pronguen pronguen removed this from the v1.3.0 milestone Mar 4, 2021
@github-actions
Copy link

github-actions bot commented Mar 2, 2022

This issue is stale because it has been open 6 months with no activity.

@github-actions github-actions bot added the stale Stale or no longer relevant label Mar 2, 2022
@github-actions github-actions bot closed this as completed Mar 2, 2022
@pronguen pronguen reopened this Mar 2, 2022
@pronguen pronguen removed the stale Stale or no longer relevant label Mar 2, 2022
@github-actions
Copy link

This issue is stale because it has been open 6 months with no activity.

@github-actions github-actions bot added the stale Stale or no longer relevant label Aug 30, 2022
@PascalRepond PascalRepond added p-Low Low priority and removed stale Stale or no longer relevant p-Medium Medium priority (to be solved within 1-2 years) labels Aug 30, 2022
@PascalRepond PascalRepond reopened this Sep 2, 2022
@PascalRepond PascalRepond added the wontfix This issue will not be addressed label Jan 30, 2023
@PascalRepond PascalRepond closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: important US candidate enhancement Improvement of an existing feature f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-Low Low priority wontfix This issue will not be addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iGormilhit @pronguen @PascalRepond