Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance issue when loading and displaying documents with many items in the public interface #1401

Closed
pronguen opened this issue Nov 5, 2020 · 3 comments · Fixed by rero/rero-ils-ui#493
Closed

Performance issue when loading and displaying documents with many items in the public interface #1401

pronguen opened this issue Nov 5, 2020 · 3 comments · Fixed by rero/rero-ils-ui#493
Labels
effort: important US candidate enhancement Improvement of an existing feature f: public ui Public interface, as opposed to the professional interface p-High High priority (to be solved in the 2-3 next months) performance
Milestone
v1.0.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Nov 5, 2020 •
edited
Loading

How it works

For documents with many items, like mangas (ex: R005112192), all items are loaded and displayed. This leads to performance problem: the page sometimes cannot be loaded.

Improvement suggestion
Only the 5 first items per holdings are loaded and displayed (sorted by field enumerationAndChronology, Z>A). A button "Show more" enables to load more items.
Ideally: the user has a search field to search for the item she/he wants.

Context

  • server: ilspilot.test.rero.ch
  • version: v0.12.0

Proposed by the pilot libraries

Discussed in grooming

Start by adding a paging to item list and holdings list.
Later (other issue): add a search field for the cases with a lot a items/holdings.

Screenshots

image
@pronguen pronguen added enhancement Improvement of an existing feature f: public ui Public interface, as opposed to the professional interface performance triage labels Nov 5, 2020
@iGormilhit iGormilhit added p-Medium Medium priority (to be solved within 1-2 years) and removed triage labels Nov 18, 2020
@iGormilhit
Copy link

Need to be verified if still relevant in v0.14.1 on the pilot server.

@benerken
Copy link
Contributor

Problem is persistent in v.0.14.
ex: https://ils.bibtest.uclouvain.be/uslb/documents/25939
It's a journal with 2 holdings, each holding has around 60 items attached => it takes 9-10 sec. to display the document.

@iGormilhit iGormilhit added this to the v1.0.0 milestone Nov 26, 2020
@iGormilhit iGormilhit added this to To do in Milestone v1.0.0 Dec 2, 2020
@iGormilhit iGormilhit added p-High High priority (to be solved in the 2-3 next months) and removed p-Medium Medium priority (to be solved within 1-2 years) labels Dec 2, 2020
@iGormilhit
Copy link

There is a related US: US 1909.

@iGormilhit iGormilhit removed this from the v1.0.0 milestone Dec 16, 2020
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jan 20, 2021
@Garfield-fr
documents: rewrite public holdings/items view in Angular
d0b8d5a 
* Implements the holdings section of the document detailed
view of the public interface to improve the user experience when
loading holdings with lots of items. With the JINJA templates, the
performance is very bad. Angular allows to lazy load data and will
make easier to add dynamic interaction between the user and the interface.
* Adds pagination on holdings of the professional interface.

* Closes rero/rero-ils#1401, closes rero/rero-ils#1577

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue Jan 20, 2021
Merged
7 tasks
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jan 20, 2021
@Garfield-fr
documents: rewrite public holdings/items view in Angular
ef96abb 
* Implements the holdings section of the document detailed
view of the public interface to improve the user experience when
loading holdings with lots of items. With the JINJA templates, the
performance is very bad. Angular allows to lazy load data and will
make easier to add dynamic interaction between the user and the interface.
* Adds pagination on holdings of the professional interface.

* Closes rero/rero-ils#1401, closes rero/rero-ils#1577

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@iGormilhit iGormilhit removed this from To do in Milestone v1.0.0 Jan 20, 2021
@iGormilhit iGormilhit added this to the v1.0.0 milestone Jan 20, 2021
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jan 21, 2021
@Garfield-fr
documents: rewrite public holdings/items view in Angular
7298580 
* Implements the holdings section of the document detailed
view of the public interface to improve the user experience when
loading holdings with lots of items. With the JINJA templates, the
performance is very bad. Angular allows to lazy load data and will
make easier to add dynamic interaction between the user and the interface.
* Adds pagination on holdings of the professional interface.

* Closes rero/rero-ils#1401
* Closes rero/rero-ils#1563
* Closes rero/rero-ils#1577

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jan 21, 2021
@Garfield-fr
documents: rewrite public holdings/items view in Angular
75c1857 
* Implements the holdings section of the document detailed
view of the public interface to improve the user experience when
loading holdings with lots of items. With the JINJA templates, the
performance is very bad. Angular allows to lazy load data and will
make easier to add dynamic interaction between the user and the interface.
* Adds pagination on holdings of the professional interface.

* Closes rero/rero-ils#1401
* Closes rero/rero-ils#1563
* Closes rero/rero-ils#1577

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jan 27, 2021
@Garfield-fr
documents: rewrite public holdings/items view in Angular
fdf40ff 
* Implements the holdings section of the document detailed
view of the public interface to improve the user experience when
loading holdings with lots of items. With the JINJA templates, the
performance is very bad. Angular allows to lazy load data and will
make easier to add dynamic interaction between the user and the interface.
* Adds pagination on holdings of the professional interface.

* Closes rero/rero-ils#1401
* Closes rero/rero-ils#1563
* Closes rero/rero-ils#1577

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jan 29, 2021
@Garfield-fr
documents: rewrite public holdings/items view in Angular
d9a85f7 
* Implements the holdings section of the document detailed
view of the public interface to improve the user experience when
loading holdings with lots of items. With the JINJA templates, the
performance is very bad. Angular allows to lazy load data and will
make easier to add dynamic interaction between the user and the interface.
* Adds pagination on holdings of the professional interface.

* Closes rero/rero-ils#1401
* Closes rero/rero-ils#1563
* Closes rero/rero-ils#1577

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jan 29, 2021
@Garfield-fr
documents: rewrite public holdings/items view in Angular
44359be 
* Implements the holdings section of the document detailed
view of the public interface to improve the user experience when
loading holdings with lots of items. With the JINJA templates, the
performance is very bad. Angular allows to lazy load data and will
make easier to add dynamic interaction between the user and the interface.
* Adds pagination on holdings of the professional interface.

* Closes rero/rero-ils#1401
* Closes rero/rero-ils#1563
* Closes rero/rero-ils#1577

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Feb 2, 2021
@Garfield-fr
documents: rewrite public holdings/items view in Angular
32d8a4c 
* Implements the holdings section of the document detailed
view of the public interface to improve the user experience when
loading holdings with lots of items. With the JINJA templates, the
performance is very bad. Angular allows to lazy load data and will
make easier to add dynamic interaction between the user and the interface.
* Adds pagination on holdings of the professional interface.

* Closes rero/rero-ils#1401
* Closes rero/rero-ils#1563
* Closes rero/rero-ils#1577

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Feb 2, 2021
@Garfield-fr
documents: rewrite public holdings/items view in Angular
0e1ec04 
* Implements the holdings section of the document detailed
view of the public interface to improve the user experience when
loading holdings with lots of items. With the JINJA templates, the
performance is very bad. Angular allows to lazy load data and will
make easier to add dynamic interaction between the user and the interface.
* Adds pagination on holdings of the professional interface.

* Closes rero/rero-ils#1401
* Closes rero/rero-ils#1563
* Closes rero/rero-ils#1577

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Feb 2, 2021
@Garfield-fr
documents: rewrite public holdings/items view in Angular
48bfcfc 
* Implements the holdings section of the document detailed
view of the public interface to improve the user experience when
loading holdings with lots of items. With the JINJA templates, the
performance is very bad. Angular allows to lazy load data and will
make easier to add dynamic interaction between the user and the interface.
* Adds pagination on holdings of the professional interface.

* Closes rero/rero-ils#1401
* Closes rero/rero-ils#1563
* Closes rero/rero-ils#1577

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Feb 3, 2021
@Garfield-fr
documents: rewrite public holdings/items view in Angular
018e11b 
* Implements the holdings section of the document detailed
view of the public interface to improve the user experience when
loading holdings with lots of items. With the JINJA templates, the
performance is very bad. Angular allows to lazy load data and will
make easier to add dynamic interaction between the user and the interface.
* Adds pagination on holdings of the professional interface.

* Closes rero/rero-ils#1401
* Closes rero/rero-ils#1563
* Closes rero/rero-ils#1577

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@iGormilhit iGormilhit changed the title Problem by loading and displaying documents with many items in the public interface Performance issue when loading and displaying documents with many items in the public interface Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: important US candidate enhancement Improvement of an existing feature f: public ui Public interface, as opposed to the professional interface p-High High priority (to be solved in the 2-3 next months) performance
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

documents: rewrite public holdings/items view in Angular Garfield-fr/rero-ils-ui
3 participants
@iGormilhit @pronguen @benerken