Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identifier qualifier, status and note should be displayed in the document detailed view #1403

Closed
pronguen opened this issue Nov 5, 2020 · 2 comments · Fixed by #1416 or rero/rero-ils-ui#421
Assignees
Labels
bug Breaks something but is not blocking enhancement Improvement of an existing feature f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface
Milestone

Comments

@pronguen
Copy link
Contributor

pronguen commented Nov 5, 2020

How it works

Concerns the public and professional interface

  • Identifier qualifier, status and note, for documents, are not displayed in the document detailed view.
  • Only the first identifier is displayed.

Improvement suggestion
Concerns the public and professional interface:

  • all identifiers are displayed
  • qualifier, status and note are displayed after the value. Exemple: [value] - [qualifier], [status], [note] [badge with the type]
  • ideally the source for identifiers of type bf:Local is displayed in the badge instead of the mention bf:Local.

Context

  • server: ilspilot.test.rero.ch
  • version: v0.12.0

Proposed by the pilot libraries

Screenshots
image

@pronguen pronguen added enhancement Improvement of an existing feature triage bug Breaks something but is not blocking labels Nov 5, 2020
@AoNoOokami AoNoOokami self-assigned this Nov 6, 2020
@AoNoOokami
Copy link
Contributor

AoNoOokami commented Nov 6, 2020

EDIT: I think I got the real purpose of this issue. Does this display meet the expectations (ping @pronguen)?

Screen Shot 2020-11-06 at 16 44 30

==================================OUTDATED=====================================

I'm investigating this issue. So far, I found that the identifiers are displayed, except for bf:Local ones. Moreover, they are displayed only if the status is valid. Is that the expected behaviour?
Example: document with pid = 240 in document_small.json
Public view:
Screen Shot 2020-11-06 at 15 04 56
Professional view:
Screen Shot 2020-11-06 at 15 05 31
Data:

"identifiedBy": [
      {
        "type": "bf:Isbn",
        "value": "9783540379508"
      },
      {
        "type": "bf:Doi",
        "value": "10.1007/978-3-540-37973-7"
      },
      {
        "source": "RERO",
        "type": "bf:Local",
        "value": "R004798098"
      }
    ]

AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 6, 2020
* Displays qualifier, status and note for identifiers.
* Closes rero#1403.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 6, 2020
* Displays qualifier, status and note for identifiers.
* Closes rero#1403.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@iGormilhit iGormilhit added f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface and removed triage labels Nov 9, 2020
@iGormilhit iGormilhit added this to the v0.14.0 milestone Nov 9, 2020
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 9, 2020
* Displays qualifier, status and note for identifiers.
* Adds identifier types to translated strings.
* Closes rero#1403.
* Closes rero#918.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@pronguen
Copy link
Contributor Author

pronguen commented Nov 9, 2020

@AoNoOokami The first display above seems to meet all requirements!

AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 9, 2020
* Displays qualifier, status and note for identifiers.
* Adds identifier types to translated strings.
* Closes rero#1403.
* Closes rero#918.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 10, 2020
* Displays qualifier, status and note for identifiers.
* Adds identifier types to translated strings.
* Closes rero#1403.
* Closes rero#918.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 10, 2020
* Displays qualifier, status and note for identifiers.
* Adds identifier types to translated strings.
* Closes rero#1403.
* Closes rero#918.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit that referenced this issue Nov 10, 2020
* Displays qualifier, status and note for identifiers.
* Adds identifier types to translated strings.
* Closes #1403.
* Closes #918.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking enhancement Improvement of an existing feature f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface
Projects
None yet
3 participants