Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log_mesh_file does not support PLY files #1571

Open
pablovela5620 opened this issue Mar 11, 2023 · 2 comments
Open

log_mesh_file does not support PLY files #1571

pablovela5620 opened this issue Mar 11, 2023 · 2 comments
Labels
😤 annoying Something in the UI / SDK is annoying to use 🐍 Python API Python logging API 🔺 re_renderer affects re_renderer itself

Comments

@pablovela5620
Copy link
Contributor

Describe the annoyance

Trying to log a .ply mesh file using the log_mesh_file but there is only support for obj/glb

Expected behavior

There should be a way to log a .ply file via log_mesh_file without needing to load the file and use log_mesh or converting the .ply file into a obj/glb format

Your goals

Trying to log a colored mesh along with bounding 3d bounding boxes/camera/images/depths

Desktop (please complete the following information):

  • OS: macOS 13.2.1 M1 Pro

Additional context

related to #1570 because there is no ply file support, had to load in the mesh using trimesh and use log_mesh instead
@pablovela5620 pablovela5620 added 👀 needs triage This issue needs to be triaged by the Rerun team 😤 annoying Something in the UI / SDK is annoying to use labels Mar 11, 2023
@pablovela5620 pablovela5620 mentioned this issue Mar 11, 2023
Merged
7 tasks
@nikolausWest nikolausWest added 🐍 Python API Python logging API 🔺 re_renderer affects re_renderer itself and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Mar 20, 2023
@emilk emilk mentioned this issue Mar 21, 2023
Open
emilk added a commit that referenced this issue Jun 27, 2023
@emilk
Add script to find external issues we haven't commented on
e91e000 
We should make people who file issues feel seen by commenting on them

Example output:

```
#1529 by rasmusgo has 0 comments
#1544 by cortwave has 0 comments
#1571 by pablovela5620 has 0 comments
```
@emilk
Copy link
Member

emilk commented Jun 27, 2023

I wonder where we we will draw the line here. Obviously easy support for many mesh formats is great, but it also comes at a cost: larger binaries, longer compilation times, larger attack surface, etc. Maybe easily integrating with some standard Python mesh library is preferable to deeply integrating ply support into the Rerun viewer. Maybe.

emilk added a commit that referenced this issue Jun 28, 2023
@emilk
Add script to find external issues we haven't commented on (#2532)
3e6e973 
### What
We should make people who file issues feel seen by commenting on them

Example output:

```
#1529 by rasmusgo has 0 comments
#1544 by cortwave has 0 comments
#1571 by pablovela5620 has 0 comments
```

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2532

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/e91e000/docs
Examples preview: https://rerun.io/preview/e91e000/examples
<!-- pr-link-docs:end -->
emilk added a commit that referenced this issue Jun 29, 2023
@emilk
Add script to find external issues we haven't commented on (#2532)
1d5df59 
### What
We should make people who file issues feel seen by commenting on them

Example output:

```
#1529 by rasmusgo has 0 comments
#1544 by cortwave has 0 comments
#1571 by pablovela5620 has 0 comments
```

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2532

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/e91e000/docs
Examples preview: https://rerun.io/preview/e91e000/examples
<!-- pr-link-docs:end -->
@teh-cmc
Copy link
Member

teh-cmc commented Dec 14, 2023

#4519 adds a simple DataLoader for 3D point clouds in ply files, but that won't be usable from the SDKs until #4526 is solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
😤 annoying Something in the UI / SDK is annoying to use 🐍 Python API Python logging API 🔺 re_renderer affects re_renderer itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@emilk @nikolausWest @teh-cmc @pablovela5620