Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide CMake install target setup #4207

Closed
Wumpf opened this issue Nov 13, 2023 · 2 comments · Fixed by #4326
Closed

Provide CMake install target setup #4207

Wumpf opened this issue Nov 13, 2023 · 2 comments · Fixed by #4326
Labels
🌊 C++ API C or C++ logging API enhancement New feature or request

Comments

@Wumpf
Copy link
Member

Wumpf commented Nov 13, 2023

Ever since we released the C++ SDK, having no cmake INSTALL is a common limitation people hit. Usecase examples:

@Wumpf Wumpf added enhancement New feature or request 🌊 C++ API C or C++ logging API labels Nov 13, 2023
@Wumpf Wumpf added this to the 0.11 C++ polish milestone Nov 13, 2023
@rishabh-slamcore
Copy link
Contributor

Tried cloning and running scripts/setup_dev.sh
It fails in scripts/setup.sh line rustup install 1.72.1
The script assumes rustup is available on my vanilla ubuntu 20.04, which is not the case.

@Wumpf
Copy link
Member Author

Wumpf commented Nov 13, 2023

@rishabh-slamcore This issue here is specifically about the C++ SDK distribution, not about building Rerun from the repository. For getting started with the repository check https://github.com/rerun-io/rerun/blob/main/BUILD.md#getting-started-with-the-repository - you first have to install rustup. The setup shell scripts aren't in a good shape generally, we gonna soon replace it with a full pixi setup, see

But worth noting you only need all of this when you want to build Rerun from the repository which is typically only when you want to modify something for a fork (with the goal of either experimenting, making personal enhancements or contributing) 🙂

@emilk emilk removed this from the 0.11 milestone Nov 21, 2023
@Wumpf Wumpf mentioned this issue Nov 23, 2023
4 tasks
Wumpf added a commit that referenced this issue Nov 24, 2023
### What

* Depends on #4313
* Fixes #4207

Support and document use of CMake install.
Minimal example has a switch to use `find_package`. Not rolling it out
to others because it's just not as ergonomic, don't want to advertise it
all that much. However, the minimal example is used in the sdk package
script to test that install is in order before uploading the package
script (runs locally). I manually tested the case of a rerun install
depend on an arrow system install.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4326) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4326)
- [Docs
preview](https://rerun.io/preview/78027bcbca31e62a27bdea34b563070eda817187/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/78027bcbca31e62a27bdea34b563070eda817187/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 C++ API C or C++ logging API enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants