-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace our setup*.sh
files with pixi
#4170
Comments
9 tasks
emilk
changed the title
Replace our
Replace our Nov 7, 2023
setup*.sh
filessetup*.sh
files with pixi
18 tasks
jprochazk
added a commit
that referenced
this issue
Nov 23, 2023
### What Part of #4170 - [x] `scripts/setup_dev.sh` - [x] ~~`cargo` tools~~ these continue to be installed via `cargo` - [x] ~~`pngcrush`~~ `pixi` does not have it, removed usage of it instead because it only seemed to have limited effects in my testing, and PIL already optimizes when saving. - [x] ~~`nox` via `pipx`~~ added `nox` directly - [x] `clang-format` - [x] `flatbuffers` - [x] `scripts/setup_web.sh` - [x] `wasm32-unknown-unknown` target (already part of `rust-toolchain` file) - [x] `binaryen` for `wasm-opt` only - [x] `scripts/setup.sh` - [x] `cmake` - Also installs a long list of _runtime_ dependencies (e.g. `gtk3`, `openssl`, `apache-arrow`), these should be specified in documentation somewhere for the most common linux distributions. - [x] `ci_docker/Dockerfile` - [x] Uses `setup_web.sh`, but it doesn't need to. We just need to ensure it installs the targets specified in `rust-toolchain` - [x] CI workflows should not use any `setup` scripts There is still a long-tail of things that need to be done before we can delete the scripts, and the scope of that is too large for this PR. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4302) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4302) - [Docs preview](https://rerun.io/preview/472fd7dc27df1b8bda0ceb02fc027c0816226d7a/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/472fd7dc27df1b8bda0ceb02fc027c0816226d7a/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
This was referenced Jan 25, 2024
Wumpf
added a commit
that referenced
this issue
Jan 26, 2024
### What * Fixes #4907 * Chips away on #4170 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/4913/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/4913/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/4913/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4913) - [Docs preview](https://rerun.io/preview/efc4b733c65083d1bc5901edb024ea125164b8e3/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/efc4b733c65083d1bc5901edb024ea125164b8e3/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
5 tasks
for an already installed cargo-cranky, |
Wumpf
added a commit
that referenced
this issue
Feb 23, 2024
… already (#5263) ### What * Part of #4170 pixi already handles binaryen. the rust target is ok to throw in as an instruction since it's fairly obvious ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5263/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5263/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5263/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5263) - [Docs preview](https://rerun.io/preview/4999a8e4b533430cd67d2cff88d8cd35b6f38b7c/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/4999a8e4b533430cd67d2cff88d8cd35b6f38b7c/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
5 tasks
Wumpf
added a commit
that referenced
this issue
Mar 18, 2024
### What Almost everything has been taken over by `pixi` by now and these outdated / partially broken scripts keep confusing new-comers to the repo, so at this point they're clearly doing more bad than good. * Fixes #5545 * Fixes #4170 * There's still some stuff that should be moved to pixi but that's better covered by #3717 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5552/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5552/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5552/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5552) - [Docs preview](https://rerun.io/preview/8da4ef3b503b5459274c73ea40bc0926b61dbae9/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/8da4ef3b503b5459274c73ea40bc0926b61dbae9/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
scripts/setup_dev.sh
scripts/setup_web.sh
scripts/setup.sh
ci_docker/Dockerfile
First part of this:
There is still quite a lot of work to do, and it comes down to us wanting to maintain two workflows:
rerun
from sourcererun
Where the former should not require
pixi
.The text was updated successfully, but these errors were encountered: