Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual glitch in a ScrollArea when two components are selected #4367

Closed
abey79 opened this issue Nov 28, 2023 · 5 comments
Closed

Visual glitch in a ScrollArea when two components are selected #4367

abey79 opened this issue Nov 28, 2023 · 5 comments
Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working egui Requires egui/eframe work ui concerns graphical user interface
Milestone
0.12

Comments

@abey79
Copy link
Member

abey79 commented Nov 28, 2023

Describe the bug

When selecting two component and make the selection panel small, a visual glitch sometimes happen with the second component.

Export-1701183489294.mp4

To Reproduce

Steps to reproduce the behavior:

  1. detect_and_track example
  2. select two components in the streams tree
  3. reduce height of selection panel
  4. scroll in selection panel

I've been able to reproduce in 0.8 and main as of today.
@abey79 abey79 added 🪳 bug Something isn't working ui concerns graphical user interface labels Nov 28, 2023
@emilk
Copy link
Member

emilk commented Nov 28, 2023

Do we do any set_clip_rect shenanigans here?

Can we create a simple repro?

I wonder if this is related to emilk/egui#2860 - does reverting it help?

@abey79
Copy link
Member Author

abey79 commented Nov 28, 2023

Do we do any set_clip_rect shenanigans here?

I dont think so.

image

Can we create a simple repro?

Not sure, haven't tried.

I wonder if this is related to emilk/egui#2860 - does reverting it help?

It happens in 0.8, which predates that PR.

@abey79
Copy link
Member Author

abey79 commented Nov 28, 2023

Playing with the glitch, I noticed that rows tend to appear at once and not be clipped. This hints that the issue might be related with how the "rows to be displayed" is calculated, rather than a pixel clipping issue.

@abey79 abey79 added the 😤 annoying Something in the UI / SDK is annoying to use label Nov 29, 2023
@emilk emilk added the egui Requires egui/eframe work label Nov 30, 2023
@abey79
Copy link
Member Author

abey79 commented Dec 1, 2023 •
edited by emilk
Loading

@abey79 abey79 modified the milestones: 0.12, 0.11 Dec 1, 2023
@abey79 abey79 mentioned this issue Dec 4, 2023
Merged
4 tasks
abey79 added a commit that referenced this issue Dec 6, 2023
@abey79 @emilk
Improve the Selection Panel UI for components when a single item is s…
9ad5a0d 
…elected (#4416)

### What

This PR:
- adds a new UI verbosity level to distinguish between single- and
multi-selection in the Selection Panel;
- adjusts `DataUi` impls accordingly;
- update the UI of for `AnnotationContext` to use collapsible headers
instead of inner scroll areas (there can be *many* tables for one
instance, so inner scroll bars are really annoying);
- adds a script to log very long `AnnotationContext` for UI test
purposes.


* Is affected by (and doesn't fix):
#4367
* Follow-up to #4370
* Fixes #4375

### Screenshot

New collapsible-header-based UI for annotation context:


https://github.com/rerun-io/rerun/assets/49431240/435566a0-420b-48d7-8ea4-026d02d903a2

Also fix this spurious separator (and the related sizing issue) at the
top of the hover box:

<img width="662" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/077a3af4-2a5d-423a-8609-46bbc4f66221">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
  * Full build: [app.rerun.io](https://app.rerun.io/pr/4416/index.html)
* Partial build:
[app.rerun.io](https://app.rerun.io/pr/4416/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
- Useful for quick testing when changes do not affect examples in any
way
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4416)
- [Docs
preview](https://rerun.io/preview/83f1bdcdcd055dd46658343a44f9ae7022c64f45/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/83f1bdcdcd055dd46658343a44f9ae7022c64f45/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

---------

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
@abey79
Copy link
Member Author

abey79 commented Dec 12, 2023

Fixed by emilk/egui#3690 and #4461

@abey79 abey79 closed this as completed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working egui Requires egui/eframe work ui concerns graphical user interface
Projects
None yet
Milestone
0.12
Development

No branches or pull requests
2 participants
@emilk @abey79