Improve component data table UI in the selection panel #4370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wondering if this should apply to more things. Like text
|
|
or annotation context |
|
@Wumpf Definitely. I already had annotation context in sight (will open an issue if I don't get to it), and surely others might need the same. Every impl is slightly different though, so it's not a dumb copy/paste. |
|
ah too bad :) |
|
I think this PR's fix is acceptable enough to be merged, but I have a plan to make it better and roll it elsewhere: #4375 |
Wumpf
approved these changes
Nov 28, 2023
emilk
reviewed
Nov 28, 2023
teh-cmc
pushed a commit
that referenced
this pull request
Nov 30, 2023
### What Improve the UI of component data tables in the selection panel. The behaviour now depends on how many items are selected. If only one is selected, the table expends to the max and relies on the selection panel's `ScrollArea`. * Fixes #3228 ### Screenshots Single selection: <img width="376" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/54eb33b7-21f0-4858-9030-f91ea3df1b53"> Multiple selections: <img width="384" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/d872c788-4bba-4ed2-b1cf-1566198fe05c"> Hover tooltip are still compact: <img width="197" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/55e9217a-c9e4-41b0-8d26-96f35c6a24f3"> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4370) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4370) - [Docs preview](https://rerun.io/preview/e51649c650146ac58f3d8df776e242b86ceb5849/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/e51649c650146ac58f3d8df776e242b86ceb5849/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
4 tasks
abey79
added a commit
that referenced
this pull request
Dec 6, 2023
…elected (#4416) ### What This PR: - adds a new UI verbosity level to distinguish between single- and multi-selection in the Selection Panel; - adjusts `DataUi` impls accordingly; - update the UI of for `AnnotationContext` to use collapsible headers instead of inner scroll areas (there can be *many* tables for one instance, so inner scroll bars are really annoying); - adds a script to log very long `AnnotationContext` for UI test purposes. * Is affected by (and doesn't fix): #4367 * Follow-up to #4370 * Fixes #4375 ### Screenshot New collapsible-header-based UI for annotation context: https://github.com/rerun-io/rerun/assets/49431240/435566a0-420b-48d7-8ea4-026d02d903a2 Also fix this spurious separator (and the related sizing issue) at the top of the hover box: <img width="662" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/077a3af4-2a5d-423a-8609-46bbc4f66221"> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Full build: [app.rerun.io](https://app.rerun.io/pr/4416/index.html) * Partial build: [app.rerun.io](https://app.rerun.io/pr/4416/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) - Useful for quick testing when changes do not affect examples in any way * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4416) - [Docs preview](https://rerun.io/preview/83f1bdcdcd055dd46658343a44f9ae7022c64f45/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/83f1bdcdcd055dd46658343a44f9ae7022c64f45/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improve the UI of component data tables in the selection panel. The behaviour now depends on how many items are selected. If only one is selected, the table expends to the max and relies on the selection panel's
ScrollArea.Screenshots
Single selection:
Multiple selections:
Hover tooltip are still compact:
Checklist