Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LICENSE file to rerun_cpp_sdk asset #4869

Closed
rgolovanov opened this issue Jan 19, 2024 · 0 comments · Fixed by #4870
Closed

Add LICENSE file to rerun_cpp_sdk asset #4869

rgolovanov opened this issue Jan 19, 2024 · 0 comments · Fixed by #4870
Labels
🌊 C++ API C/C++ API specific enhancement New feature or request

Comments

@rgolovanov
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently the SDK is distributed without license file, however LICENSE is available in the repository. It would be good to make it part of SDK asset so integrators (users) would have everything in place for integrations with their proprietary software.

Describe the solution you'd like
Just add LICENSE files into SDK archives.
@rgolovanov rgolovanov added enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team labels Jan 19, 2024
@rgolovanov rgolovanov mentioned this issue Jan 19, 2024
Merged
4 tasks
emilk pushed a commit that referenced this issue Jan 19, 2024
@rgolovanov
Include LICENSE files into C++ SDK Assets (#4870)
c9202aa 
Adds License files to C++ SDK assets

<!--
Open the PR up as a draft until you feel it is ready for a proper
review.

Do not make PR:s from your own `main` branch, as that makes it difficult
for reviewers to add their own fixes.

Add any improvements to the branch as new commits to make it easier for
reviewers to follow the progress. All commits will be squashed to a
single commit once the PR is merged into `main`.

Make sure you mention any issues that this PR closes in the description,
as well as any other related issues.

To get an auto-generated PR description you can put "copilot:summary" or
"copilot:walkthrough" anywhere.
-->

### What

Resolves #4869 

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4870/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4870/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4870/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4870)
- [Docs
preview](https://rerun.io/preview/14755ca66eec760f8a6fdb4a881879fa4bbaab2f/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/14755ca66eec760f8a6fdb4a881879fa4bbaab2f/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
@Wumpf Wumpf added 🌊 C++ API C/C++ API specific and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🌊 C++ API C/C++ API specific enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include LICENSE files into C++ SDK Assets rgolovanov/rerun
2 participants
@Wumpf @rgolovanov