Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup_dev.sh issue with cargo install typos-cli #4907

Closed
ricardonunosr opened this issue Jan 25, 2024 · 1 comment · Fixed by #4913
Closed

setup_dev.sh issue with cargo install typos-cli #4907

ricardonunosr opened this issue Jan 25, 2024 · 1 comment · Fixed by #4913
Labels
🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI) 🏎️ Quick Issue Can be fixed in a few hours or less

Comments

@ricardonunosr
Copy link

ricardonunosr commented Jan 25, 2024 •
edited
Loading

Describe the bug
Running the command ./scripts/setup_dev.sh causes error while installing typos-cli.

typos-cli need rust 1.75.0 since version 1.17.0 of typos-cli
image

Some ideas:

  • the setup_dev.sh use the pixi tool. Use pixi shell to have all of rerun environment ready
  • lock the version in Cargo.toml use --locked in the script

To Reproduce
Steps to reproduce the behavior:

  1. Run ./scripts/setup_dev.sh on a machine without typos-cli
  2. Error occurs while compiling crate

Expected behavior
Expect script to install dependencies without errors

Screenshots
image

Desktop (please complete the following information):

  • OS: macOS Ventura 13.3.1
@ricardonunosr ricardonunosr added 👀 needs triage This issue needs to be triaged by the Rerun team 🪳 bug Something isn't working labels Jan 25, 2024
@Wumpf
Copy link
Member

Wumpf commented Jan 25, 2024

Typos is already part of the pixi.toml, so this should be removed from the script as we're phasing them out, see

@Wumpf Wumpf added 🧑‍💻 dev experience developer experience (excluding CI) 🏎️ Quick Issue Can be fixed in a few hours or less and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Jan 25, 2024
@Wumpf Wumpf mentioned this issue Jan 25, 2024
Merged
4 tasks
Wumpf added a commit that referenced this issue Jan 26, 2024
@Wumpf
Run taplo and typos always via pixi (#4913)
b18c182 
### What

* Fixes #4907
* Chips away on #4170


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4913/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4913/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4913/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4913)
- [Docs
preview](https://rerun.io/preview/efc4b733c65083d1bc5901edb024ea125164b8e3/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/efc4b733c65083d1bc5901edb024ea125164b8e3/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI) 🏎️ Quick Issue Can be fixed in a few hours or less
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run taplo and typos always via pixi rerun-io/rerun
2 participants
@Wumpf @ricardonunosr