Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu: add relevant context menu to tile title widget and container children list #5300

Closed
abey79 opened this issue Feb 27, 2024 · 0 comments · Fixed by #5321
Closed
Assignees
Labels
🏎️ Quick Issue Can be fixed in a few hours or less ui concerns graphical user interface

Comments

@abey79
Copy link
Contributor

abey79 commented Feb 27, 2024

These places must have context menu:

image image



Note: the way triggering the context menu affects the selection might need to be adjusted depending on the context. In particular, the context menu should not change the selection in the selection panel.

@abey79 abey79 added the ui concerns graphical user interface label Feb 27, 2024
@abey79 abey79 self-assigned this Feb 27, 2024
@abey79 abey79 added the 🏎️ Quick Issue Can be fixed in a few hours or less label Feb 27, 2024
abey79 added a commit that referenced this issue Feb 28, 2024
…ainer's children list (#5321)

### What

As the title says ☝🏻
Fixes #5300 

To meaningfully accomodate with these additional contexts, the
`context_menu_ui_for_item` function now support various modes of
interaction with the selection:
- blueprint tree: consider the multi-selection if the clicked item is
part of it, otherwise set selection to clicked item
- tab title: always set selection to clicked item
- container selection panel children list: ignore the selection

<img width="286" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/bb711e87-cec2-4d01-b06c-9b35f8e621aa">
<img width="343" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/517de1b9-952c-4e04-97f1-890b4c02076f">




### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5321/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5321/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5321/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5321)
- [Docs
preview](https://rerun.io/preview/64784da9acec90763d8727d3463ad90980d550db/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/64784da9acec90763d8727d3463ad90980d550db/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏎️ Quick Issue Can be fixed in a few hours or less ui concerns graphical user interface
Projects
None yet
1 participant