Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for context menu for viewport tab title and selected container's children list #5321

Merged
merged 8 commits into from Feb 28, 2024

Conversation

abey79
Copy link
Contributor

@abey79 abey79 commented Feb 27, 2024

What

As the title says ☝🏻
Fixes #5300

To meaningfully accomodate with these additional contexts, the context_menu_ui_for_item function now support various modes of interaction with the selection:

  • blueprint tree: consider the multi-selection if the clicked item is part of it, otherwise set selection to clicked item
  • tab title: always set selection to clicked item
  • container selection panel children list: ignore the selection
image image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@abey79 abey79 added ui concerns graphical user interface include in changelog labels Feb 27, 2024
@Wumpf Wumpf self-requested a review February 28, 2024 10:15
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting idea with SelectionUpdateBehavior. Personally, I find the choices a bit arbitrary, but works out overall to ux that I would not call intuitive :)

crates/re_viewport/src/viewport.rs Outdated Show resolved Hide resolved
@abey79
Copy link
Contributor Author

abey79 commented Feb 28, 2024

interesting idea with SelectionUpdateBehavior. Personally, I find the choices a bit arbitrary, but works out overall to ux that I would not call intuitive :)

I agree, it's totally ad hoc, and based on what made more sense to me for the various contexts involved.

@abey79 abey79 merged commit 38ca677 into main Feb 28, 2024
39 checks passed
@abey79 abey79 deleted the antoine/cm-tab-title-and-children-list branch February 28, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context menu: add relevant context menu to tile title widget and container children list
2 participants