New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be extra thorough testing version switching between 0.15 / 0.16 and trying to load cross-version blueprints #6213

Closed

jleibs opened this issue May 3, 2024 · 1 comment

Assignees

Labels

Milestone

Member

jleibs commented May 3, 2024

Look for sane behavior, appropriate warnings for version mismatches, etc.

jleibs added the 🟦 blueprint label

jleibs added this to the 0.16 milestone

jleibs self-assigned this

jleibs mentioned this issue

Validate the blueprint schema when we try to activate a blueprint sent from SDK #6283

Merged

5 tasks

jleibs added a commit that referenced this issue


          Validate the blueprint schema when we try to activate a blueprint sen…

3a42904

…t from SDK (#6283)

### What
- Partially addresses: #6213

We already used to validate on load from file, but this pulls the
validation into the default/activation pathways.
This keeps us from getting into a state where we can't write to the
blueprint due to components with inconsistent schemas.

- Future work: #6282

Unfortunately we can still get issues when opening 0.16 blueprints in
0.15 viewers since 0.15 is missing this validation.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6283?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6283?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6283)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.

Member

Wumpf commented May 16, 2024

we did that

Wumpf closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment