"Visible Time Range" doesn't work with transforms #723
Labels
🪳 bug
Something isn't working
📺 re_viewer
affects re_viewer itself
user-request
This is a pressing issue for one of our users
Comments
Wumpf
added a commit
that referenced
this issue
Nov 28, 2023
### What * Fixes #4267 TODO for final release: * [x] Update links, fix all `?speculative-link` * [x] cherry pick #4349 * [x] cherry pick #4350 * [x] cherry pick #4351 * [x] cherry pick #4354 * [x] Write changelog (and review thereof) * Known limitation of Visible History worth mentioning: * [x] #4270 * [x] #723 * [x] testing: * special care this time about: * Blueprint error messages (use outdated stuff you have on your machine to stretch it!) * UI changes (selection panel, visual history things - in particular on the plot) * C++ cmake install (follow public instructions - if they don't help the instructions are bad!) * [x] Windows * [x] Native * blueprint ok 0.10.0-rc.1 -> 0.11-rc.1 * found spurious wgpu related crash, seems to be fixed on latest wgpu. Details on Slack * C++ visual studio project for unziped sdk works * Cmake install works. With path with spaces after applying #4351 * [x] Browser * [x] Linux * [x] Native * [x] Browser * [x] Mac * [x] Native * [x] blueprint ok 0.10.1 -> 0.11 * [x] UI changes ok * [x] Browser * [x] python package (any platform) * [x] tested on mac, seems ok except: * [x] ~~couldn't load example rrds~~ fixed * [x] C++ cmake install (any platform) * tested on linux * [x] Rust crate (any platform) * [x] finish opencv/eigen example update TODO just after release: * [x] Update webpage with blog * [x] Merge opencv/eigen example update * [x] github release update * [x] post on social ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4347) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4347) - [Docs preview](https://rerun.io/preview/01b4186b37fc910491879dfd90433aeb940a5c89/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/01b4186b37fc910491879dfd90433aeb940a5c89/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com> Co-authored-by: rerun-bot <bot@rerun.io> Co-authored-by: jprochazk <1665677+jprochazk@users.noreply.github.com> Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
teh-cmc
changed the title
teh-cmc
pushed a commit
that referenced
this issue
Nov 30, 2023
### What * Fixes #4267 TODO for final release: * [x] Update links, fix all `?speculative-link` * [x] cherry pick #4349 * [x] cherry pick #4350 * [x] cherry pick #4351 * [x] cherry pick #4354 * [x] Write changelog (and review thereof) * Known limitation of Visible History worth mentioning: * [x] #4270 * [x] #723 * [x] testing: * special care this time about: * Blueprint error messages (use outdated stuff you have on your machine to stretch it!) * UI changes (selection panel, visual history things - in particular on the plot) * C++ cmake install (follow public instructions - if they don't help the instructions are bad!) * [x] Windows * [x] Native * blueprint ok 0.10.0-rc.1 -> 0.11-rc.1 * found spurious wgpu related crash, seems to be fixed on latest wgpu. Details on Slack * C++ visual studio project for unziped sdk works * Cmake install works. With path with spaces after applying #4351 * [x] Browser * [x] Linux * [x] Native * [x] Browser * [x] Mac * [x] Native * [x] blueprint ok 0.10.1 -> 0.11 * [x] UI changes ok * [x] Browser * [x] python package (any platform) * [x] tested on mac, seems ok except: * [x] ~~couldn't load example rrds~~ fixed * [x] C++ cmake install (any platform) * tested on linux * [x] Rust crate (any platform) * [x] finish opencv/eigen example update TODO just after release: * [x] Update webpage with blog * [x] Merge opencv/eigen example update * [x] github release update * [x] post on social ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4347) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4347) - [Docs preview](https://rerun.io/preview/01b4186b37fc910491879dfd90433aeb940a5c89/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/01b4186b37fc910491879dfd90433aeb940a5c89/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com> Co-authored-by: rerun-bot <bot@rerun.io> Co-authored-by: jprochazk <1665677+jprochazk@users.noreply.github.com> Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
All transforms ignore the visible history field so far.
To Reproduce
It's best visible in the transforms3d demo of api_demo where everything on screen is logged only once but has changing transforms over time.
Expected behavior
For the demo in particular it's natural to expect traces of the planets as they go
Additional context
The underlying issue is that the transform cache doesn't know anything about visible history so far. Fixing this might be a bigger undertaking as it means that transforms shouldn't be queried & computed via the object path alone
The text was updated successfully, but these errors were encountered: