Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve colmap example #1008

Merged
merged 12 commits into from
Jan 31, 2023
Merged

Improve colmap example #1008

merged 12 commits into from
Jan 31, 2023

Commits on Jan 31, 2023

  1. Fix identifiers handling in log_points

    @nikolausWest
    nikolausWest committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    021cc0a View commit details
    Browse the repository at this point in the history

  2. Log both keypoints and 3D points with sorted unique identifiers

    @nikolausWest
    nikolausWest committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    540066e View commit details
    Browse the repository at this point in the history

  3. Remove identifiers form colmap logs

    @nikolausWest
    nikolausWest committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    f330e61 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary format strings

    @nikolausWest
    nikolausWest committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    19694d9 View commit details
    Browse the repository at this point in the history

  5. Break out constant

    @nikolausWest
    nikolausWest committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    ef08215 View commit details
    Browse the repository at this point in the history

  6. Use einops for clarity when rearranging

    @nikolausWest
    nikolausWest committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    e3885a8 View commit details
    Browse the repository at this point in the history

  7. add einops dependency

    @nikolausWest
    nikolausWest committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    ca23287 View commit details
    Browse the repository at this point in the history

  8. fix quaternion rearrange

    @nikolausWest
    nikolausWest committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    b1dd507 View commit details
    Browse the repository at this point in the history

  9. Revert "Use einops for clarity when rearranging" 

    This reverts commit e3885a8.
    @nikolausWest
    nikolausWest committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    aa2783e View commit details
    Browse the repository at this point in the history

  10. Remove einops again

    @nikolausWest
    nikolausWest committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    690225c View commit details
    Browse the repository at this point in the history

  11. Document FILTER_MIN_VISIBLE constant

    @nikolausWest
    nikolausWest committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    500007a View commit details
    Browse the repository at this point in the history

  12. Fix type for identifiers in log_points

    @nikolausWest
    nikolausWest committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    77e0181 View commit details
    Browse the repository at this point in the history