Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve colmap example #1008

Merged
merged 12 commits into from
Jan 31, 2023
Merged

Improve colmap example #1008

merged 12 commits into from
Jan 31, 2023

Conversation

nikolausWest
Copy link
Member

Makes the 2D keypoints colored and match the 3D points

Screenshot 2023-01-31 at 14 13 15

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@nikolausWest nikolausWest added the examples Issues relating to the Rerun examples label Jan 31, 2023
emilk
emilk reviewed Jan 31, 2023
View reviewed changes
rerun_py/rerun/log/points.py Outdated Show resolved Hide resolved
@nikolausWest nikolausWest changed the title Niko/improve colmap example Improve colmap example Jan 31, 2023
@nikolausWest nikolausWest merged commit feb8411 into main Jan 31, 2023
@nikolausWest nikolausWest deleted the niko/improve-colmap-example branch January 31, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs left review comments

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
examples Issues relating to the Rerun examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikolausWest @emilk @jleibs