Improve colmap example #1008

nikolausWest · 2023-01-31T13:14:38Z

Makes the 2D keypoints colored and match the 3D points

I have read and agree to Contributor Guide and the Code of Conduct
I've included a screenshot or gif (if applicable)
I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

This reverts commit e3885a8.

examples/colmap/main.py

rerun_py/rerun/log/points.py

nikolausWest added 10 commits January 31, 2023 12:00

Fix identifiers handling in log_points

021cc0a

Log both keypoints and 3D points with sorted unique identifiers

540066e

Remove identifiers form colmap logs

f330e61

Remove unnecessary format strings

19694d9

Break out constant

ef08215

Use einops for clarity when rearranging

e3885a8

add einops dependency

ca23287

fix quaternion rearrange

b1dd507

Revert "Use einops for clarity when rearranging"

aa2783e

This reverts commit e3885a8.

Remove einops again

690225c

nikolausWest added the examples Issues relating to the Rerun examples label Jan 31, 2023

emilk reviewed Jan 31, 2023

View reviewed changes

examples/colmap/main.py Show resolved Hide resolved

emilk reviewed Jan 31, 2023

View reviewed changes

rerun_py/rerun/log/points.py Outdated Show resolved Hide resolved

emilk approved these changes Jan 31, 2023

View reviewed changes

nikolausWest changed the title ~~Niko/improve colmap example~~ Improve colmap example Jan 31, 2023

nikolausWest added 2 commits January 31, 2023 14:29

Document FILTER_MIN_VISIBLE constant

500007a

Fix type for identifiers in log_points

77e0181

nikolausWest merged commit feb8411 into main Jan 31, 2023

nikolausWest deleted the niko/improve-colmap-example branch January 31, 2023 16:21

Provide feedback