[re_renderer] fix bindgroup reuse regression #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🪳 bug
teh-cmc
reviewed
Feb 26, 2023
…ix-bindgroup-reuse-regression
teh-cmc
approved these changes
Feb 27, 2023
emilk
pushed a commit
that referenced
this pull request
Mar 2, 2023
* Fix dynamic resource pool handles not being stable on re-use * Add test for dynamic resource pool handles not changing upon resource re-use * DynamicResourcePool debug asserts now on missing resources on deallocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused a subtle bug in #1374 that made "weak" handles no longer stable accross intra-frame resource re-use. This in turn caused the BindGroupPool to fail to re-use bindgroups from previous frames as it stores weak handles in its descriptor.
In other words,
RUST_LOG=debug cargo run --example 2dgot very spammy, now it is nice and quiet again!Added a test to prevent this from breaking again.
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)