[re_renderer] Interior mutable buffer/texture/bindgroup pools #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resource directly. Respective pools can now allocate with a & reference, no mut required
Wumpf
changed the title
emilk
reviewed
Feb 22, 2023
| 0, | ||
| index_buffer_size.try_into().unwrap(), | ||
| ) | ||
| .write_buffer_with(&index_buffer, 0, index_buffer_size.try_into().unwrap()) | ||
| .unwrap(); // Fails only if mapping is bigger than buffer size. |
There was a problem hiding this comment.
unrelated, but there is a lot of scary unwraps in this code
There was a problem hiding this comment.
all of those write_buffer_with will soon be replaced with the staging belt, making them at least look less scary 🙃
emilk
reviewed
Feb 22, 2023
| state.alive_resources.retain(|_, resource| { | ||
| let resolved = resource | ||
| .take() | ||
| .expect("Alive resources should never be None"); |
There was a problem hiding this comment.
then why use an Option in alive_resources?? O.o
There was a problem hiding this comment.
ah ok, it needs to be taken here so we can unwrap it.
There was a problem hiding this comment.
yeah that whole thing is a bit of an annoying workaround
emilk
reviewed
Feb 22, 2023
| @@ -56,10 +76,16 @@ where | |||
| Handle: Key, | |||
| Desc: Clone + Eq + Hash + Debug + SizedResourceDesc, | |||
| { | |||
| pub fn alloc<F: FnOnce(&Desc) -> Res>(&mut self, desc: &Desc, creation_func: F) -> Arc<Handle> { | |||
| pub fn alloc<F: FnOnce(&Desc) -> Res>( | |||
| &self, | |||
There was a problem hiding this comment.
so alloc is now thread-safe? that's very nice!
emilk
approved these changes
Feb 22, 2023
teh-cmc
approved these changes
Feb 22, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows allocating buffers/textures/bindgroups without a
mutreference to the pool.Moved
wgpu::Bufferownership from slotmap inside the pool to the strong handle itself, simplifying a lot of callsites.Some ripple effects on
DrawDatalifetime requirements and that in turn onto howViewBuilderare composited - needed to do a workaround for the egui integration case.Checklist
CHANGELOG.md(if this is a big enough change to warrant it)