Refactor: re_sdk no longer depends on re_viewer
#1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lib target `re_viewer` in package `re_viewer v0.2.0 (/Users/emilk/code/rerun/rerun/crates/re_viewer)` has the same output filename as the lib target `re_viewer` in package `re_viewer v0.2.0 (/Users/emilk/code/rerun/rerun/crates/re_viewer)`.
emilk
added
🦀 Rust API
❯ cargo update -p tempfile
Updating crates.io index
Removing remove_dir_all v0.5.3
Updating tempfile v3.3.0 -> v3.4.0
teh-cmc
approved these changes
Mar 6, 2023
* add rustc & llvm version to build crates * integrate everywhere * crash handler too
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All dependencies on
re_viewerhave been moved fromre_sdkto thereruncrate.This means we could start using
re_sdkfromre_viewer, i.e. have rerun bite its own tail.Breaking changes
session.spawn(…)->rerun::native_viewer::spawn(session, …)session.show()->rerun::native_viewer::show(session)session.serve(…)->rerun::serve_web_viewer(session, …);rerun::global_sessionis now hidden behind theglobal_sessionfeature flagRefactor
Sessionnow pipes the log stream to aBox<dyn LogSink>. This means we give the user full control of theSessionbackend withSession::set_sink..connect(),.save()and.serve()are just convenience methods for installing a new sink.Other
The
serve_web_viewer()method needs a tokio runtime in order to spawn the servers. This tokio runtime is still stored in theSession, but it is a bit weird. I would like to split upserve_web_viewer()anyhow, since it currently does two things (serve the web viewer, and host a websocket server). Anyways, I did the minimally intrusive thing here for now.Checklist