New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default_enabled correctly in python init #1517

Merged

jleibs merged 1 commit into release-0.3.0 from jleibs/redetermine_enabled

Mar 6, 2023

Member

jleibs commented Mar 6, 2023 •

edited

Loading

The fix in https://github.com/rerun-io/rerun/pull/1516/files was incomplete and causes the environment variables to be ignored.

Ironically #1507 also contained a fix for this issue.

Checklist

I have read and agree to Contributor Guide and the Code of Conduct
I've included a screenshot or gif (if applicable)


          Only set default_enabled not enabled

72f04c0

jleibs marked this pull request as ready for review

March 6, 2023 20:48

jleibs added the 🐍 Python API label

teh-cmc approved these changes

View reviewed changes

jleibs merged commit 2c03d2f into release-0.3.0

jleibs deleted the jleibs/redetermine_enabled branch

March 6, 2023 20:56

jleibs added a commit that referenced this pull request


          Only set default_enabled, not enabled, from python init (#1517)

c40addf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐍 Python API