Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix web feature name in error messages #1521

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Fix web feature name in error messages #1521

merged 2 commits into from
Mar 7, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Mar 6, 2023

Because few things are more annoying than an error message telling you lies 😬

@teh-cmc teh-cmc added 😤 annoying Something in the UI / SDK is annoying to use 🚜 refactor Change the code, not the functionality 📺 re_viewer affects re_viewer itself labels Mar 6, 2023
@Wumpf
Copy link
Member

Wumpf commented Mar 6, 2023

should cherry-pick to release-0.3.0 :)

@teh-cmc teh-cmc merged commit 3566bc9 into main Mar 7, 2023
@teh-cmc teh-cmc deleted the cmc/web_viewer_not_web branch March 7, 2023 13:42
@emilk emilk changed the title fix web feature name in error messages Fix web feature name in error messages Mar 27, 2023
@emilk emilk mentioned this pull request Mar 27, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
😤 annoying Something in the UI / SDK is annoying to use 📺 re_viewer affects re_viewer itself 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teh-cmc @Wumpf