Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix web feature name in error messages #1521

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Fix web feature name in error messages #1521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3943ab4
fix web feature name
teh-cmc Mar 6, 2023
55df86a
fmt
teh-cmc Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions crates/rerun/src/run.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ struct Args {
port: u16,

/// Start the viewer in the browser (instead of locally).
/// Requires Rerun to have been compiled with the 'web' feature.
/// Requires Rerun to have been compiled with the 'web_viewer' feature.
#[clap(long)]
web_viewer: bool,

Expand Down Expand Up @@ -321,7 +321,9 @@ async fn run_impl(
#[cfg(not(feature = "web_viewer"))]
{
_ = (call_source, rx);
anyhow::bail!("Can't host web-viewer - rerun was not compiled with the 'web' feature");
anyhow::bail!(
"Can't host web-viewer - rerun was not compiled with the 'web_viewer' feature"
);
}
} else {
#[cfg(feature = "native_viewer")]
Expand Down Expand Up @@ -415,7 +417,7 @@ async fn host_web_viewer(rerun_ws_server_url: String) -> anyhow::Result<()> {

#[cfg(not(feature = "web_viewer"))]
async fn host_web_viewer(_rerun_ws_server_url: String) -> anyhow::Result<()> {
panic!("Can't host web-viewer - rerun was not compiled with the 'web' feature");
panic!("Can't host web-viewer - rerun was not compiled with the 'web_viewer' feature");
}

#[cfg(feature = "server")]
Expand Down
2 changes: 1 addition & 1 deletion rerun_py/src/python_bridge.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ fn serve(open_browser: bool) -> PyResult<()> {
{
_ = open_browser;
Err(PyRuntimeError::new_err(
"The Rerun SDK was not compiled with the 'web' feature",
"The Rerun SDK was not compiled with the 'web_viewer' feature",
))
}
}
Expand Down