Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use outlines for mesh selections instead of highlight colors #1540

Merged
merged 7 commits into from Mar 9, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 9, 2023

Uses outlines for selection/hovering of meshes.

mesh.outlines.sd.mov

Introduces a sibling data structure to SpaceViewEntityHighlight in order to quickly get the desired grouping-aware outline mask indices, called SpaceViewOutlineMasks. SpaceViewOutlineMasks will likely fully replace SpaceViewEntityHighlightin the near future; in any case a bit more work in this area is needed; consider this a first quick-and-dirty step!

Color choices etc. are not considered final, but a first step. We'll go over them again when everything is changed to outlines instead of highlights.

Copy pasting a few other notes I posted previously on the internal Slack:

*Previously, we distinguished “sibling selections”, i.e. you select something in one space view and there is a different (!) highlight in another space view where the same object is visible. That’s gone now because I can only support 2 channels at the moment

  • (hardly visible in video) when an object outline is “see through” is not always intuitive in particular in regards to hover highlights. This happens because the the outline mask texture uses the same depth buffer for both selection & hover (but then computes different distance/voronoi values for each). In my humble defense, Blender has the exact same issues if one pays a lot of attention (but they don’t have hover, alas though a primary vs secondary selection which)
  • our selection color is awfully dark. I had to brighten it up a bit but it still feels to dark. This means I need to make the lines thicker than I want to (the outline impl is fairly good with large outlines, but I didn’t actually want those)
  • I’m again not happy with the anti-aliasing quality on non-4k screen. To be revisited. Might also just hint at me being obsessed at this point
  • giving the hover outline some additive transparency feels really nice
  • oh my god this so much better, the bar was low tho

Checklist

part of #889

@Wumpf Wumpf added 🔺 re_renderer affects re_renderer itself 📺 re_viewer affects re_viewer itself labels Mar 9, 2023
@Wumpf Wumpf changed the title Andreas/mesh outlines in viewer Use outlines for mesh selections instead of highlight colors Mar 9, 2023
@Wumpf Wumpf force-pushed the andreas/mesh-outlines-in-viewer branch from 3394d00 to b48a7c7 Compare March 9, 2023 10:08
@teh-cmc teh-cmc self-requested a review March 9, 2023 10:54
@Wumpf Wumpf force-pushed the andreas/mesh-outlines-in-viewer branch from b48a7c7 to 4c3ea36 Compare March 9, 2023 14:32
Base automatically changed from andreas/re_renderer/outlines to main March 9, 2023 17:29
@Wumpf Wumpf force-pushed the andreas/mesh-outlines-in-viewer branch from 4c3ea36 to a19d961 Compare March 9, 2023 17:37
crates/re_renderer/src/renderer/outlines.rs Outdated Show resolved Hide resolved
@Wumpf Wumpf merged commit a0c4189 into main Mar 9, 2023
@Wumpf Wumpf deleted the andreas/mesh-outlines-in-viewer branch March 9, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔺 re_renderer affects re_renderer itself 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants