Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using undefined extern "C" on windows #1577

Merged
merged 2 commits into from Mar 14, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Mar 13, 2023

This trick appears not to have worked on windows.

See: https://github.com/rerun-io/rerun/actions/runs/4406095342/jobs/7717895318

msvc\\lib\\rustlib\\etc\\libcore.natvis" "/NATVIS:C:\\Users\\runneradmin\\.rustup\\toolchains\\1.67-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\libstd.natvis"
  = note:    Creating library C:\a\rerun\rerun\target\x86_64-pc-windows-msvc\release\deps\re_viewer.dll.lib and object C:\a\rerun\rerun\target\x86_64-pc-windows-msvc\release\deps\re_viewer.dll.exp
          libre_log_types-c3e4ebfd91fc6bfd.rlib(re_log_types-c3e4ebfd91fc6bfd.re_log_types.67a257e1-cgu.6.rcgu.o) : error LNK2019: unresolved external symbol do_not_call_into_iter referenced in function _ZN135_$LT$$RF$re_log_types..component_types..arrow_convert_shims..BufferBinaryArray$u20$as$u20$core..iter..traits..collect..IntoIterator$GT$9into_iter17h35db1eaabf37072bE
          C:\a\rerun\rerun\target\x86_64-pc-windows-msvc\release\deps\re_viewer.dll : fatal error LNK1120: 1 unresolved externals

Instead use panic! as we have elsewhere.

Wheel-building results: https://github.com/rerun-io/rerun/actions/runs/4410197859

Checklist

@jleibs jleibs marked this pull request as ready for review March 13, 2023 22:39
@jleibs jleibs added the 🪳 bug Something isn't working label Mar 13, 2023
@jleibs jleibs merged commit beb49b1 into main Mar 14, 2023
@jleibs jleibs deleted the jleibs/avoid_windows_unresolved branch March 14, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants