Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on allocation tracker at run-time and for web #1591

Merged
merged 18 commits into from
Mar 16, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 15, 2023

Part of investigating #909

Also:

  • Clean up the copied callstack
  • Fix copy/paste of web viewer
  • Fix backtraces on web

Example web callstack:

wgpu_hal::gles::device::<impl wgpu_hal::Device<wgpu_hal::gles::Api> for wgpu_hal::gles::Device>::create_buffer
wgpu_core::device::queue::prepare_staging_buffer
wgpu_core::device::queue::<impl wgpu_core::hub::Global<G>>::queue_write_buffer
<wgpu::backend::direct::Context as wgpu::context::Context>::queue_write_buffer
<T as wgpu::context::DynContext>::queue_write_buffer
wgpu::Queue::write_buffer
egui_wgpu::renderer::Renderer::update_buffers
<eframe::web::web_painter_wgpu::WebPainterWgpu as eframe::web::web_painter::WebPainter>::paint_and_update_textures
eframe::web::backend::AppRunner::paint
eframe::web::events::paint_and_schedule

Checklist

@emilk emilk added 🕸️ web regarding running the viewer in a browser 🧑‍💻 dev experience developer experience (excluding CI) labels Mar 15, 2023
@emilk emilk force-pushed the emilk/improve-memory-tracker branch from 83b9ec5 to 4199688 Compare March 15, 2023 15:00
@Wumpf Wumpf self-requested a review March 16, 2023 09:51
crates/re_viewer/src/ui/memory_panel.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/memory_panel.rs Outdated Show resolved Hide resolved
@emilk emilk changed the title Turn on allocation tracker at run-time Turn on allocation tracker at run-time and for web Mar 16, 2023
@emilk emilk merged commit 364f86d into main Mar 16, 2023
@emilk emilk deleted the emilk/improve-memory-tracker branch March 16, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants