Upload the colmap rrd file to gcloud #1666
Conversation
jleibs
force-pushed
the
jleibs/upload_rrd
branch
from
ecbfd3b
to
9caf9de
Compare
* Serve a different index.html and url for the hosted app.rerun.io * Add index_bundled.html * Finish comment * consistent naming for colmap_fiat.rrd
I agree |
| parent: false | ||
|
|
||
| - name: "Upload RRD (tagged)" | ||
| if: startsWith(github.ref, 'refs/tags/v') |
There was a problem hiding this comment.
Maybe we should do if: startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/tags/latest' here and elsewhere to always get a latest web viewer automatically
There was a problem hiding this comment.
Generally agree but I'm going to handle the latest / prerelease logic a bit differently in another PR. There's a bit of a mess around what does / doesn't trigger a workflow. github.ref doesn't mean "this commit happens to be tagged with latest" but rather "pushing the tag latest is what triggered this workflow." But running the whole pipeline a second time (including wheel building on all platforms) seems heavy-handed to effectively update a pointer.
emilk
changed the title
This dependency logic is a bit awkward, but in lieu of a larger workflow reorganization this is the easiest path to uploading an rrd file to gcloud.
In short: we generate an rrd file when producing the wheels (and also need the wheels in order to produce the colmap rrd). This means any time we build wheels we will also upload an rrd file, but this is the same conditions where we upload the web asserts.
In the future it would be nice to have wheel-building, rrd-generation, and web-uploading all in a single workflow instead of the way they are split up at the moment. The "python vs rust" partitioning isn't actually buying us much.
Checklist