Serve a different index.html and url for the hosted app.rerun.io #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
commented
Mar 21, 2023
| @@ -0,0 +1,163 @@ | |||
| <!DOCTYPE html> | |||
| <!-- The version of index.html bundled with the Rerun SDK. --> | |||
There was a problem hiding this comment.
This is the only change relative to the original index.html
jleibs
force-pushed
the
jleibs/app_rrd_path
branch
from
650052d
to
78fdd1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the default behavior of app.reun.io to load an rrd (also hosted at app.rerun.io).
This introduces a new index.html specifically for app.rerun.io, and does a bit of different url-handling in this case. We want to use the same basic path to get an rrd file from the matching commit or version.
For the bundled app we now serve index_bundle.html, which still defaults to the websocket connection as before.
Builds on top of: https://github.com/rerun-io/rerun/pull/1666/files
See the results here:
Checklist