New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show the mobile OS warning banner on web #1685

Merged

emilk merged 1 commit into main from jleibs/limit_banner_to_web

Mar 23, 2023

Member

jleibs commented Mar 23, 2023 •

edited

Loading

A silly bug in egui means windows currently reports as android. Work-around by limiting the banner to web for now.

Fixed here:

Fix the OS check for windows emilk/egui#2832

Checklist

I have read and agree to Contributor Guide and the Code of Conduct
I've included a screenshot or gif (if applicable)


          Only show the mobile OS warning banner on web

def9ebf

jleibs added the ui label

jleibs marked this pull request as ready for review

March 23, 2023 13:41

emilk approved these changes

View reviewed changes

emilk merged commit 6e77012 into main

emilk deleted the jleibs/limit_banner_to_web branch

March 23, 2023 14:17

emilk mentioned this pull request

Add a script that generates a changelog from recent PRs and their labels #1718

Merged

1 task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui