Make CpuWriteGpuReadBelt texture copies easier/less error prone #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
changed the title
Wumpf
changed the title
Wumpf
force-pushed
the
andreas/re_renderer/nicer-texture-copies
branch
2 times, most recently
from
6d9ee89
to
fd033ec
Compare
teh-cmc
approved these changes
Mar 24, 2023
|
I have no idea why this says I asked a review from Emil btw |
Base automatically changed from
andreas/re_renderer/gpuwritecpureadbelt
to
main
March 27, 2023 08:37
And has a much stronger debug check
Wumpf
force-pushed
the
andreas/re_renderer/nicer-texture-copies
branch
from
fd033ec
to
2315a7e
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And has a much stronger debug check.
In fact it found a bug (kinda) where we wrote undetermined color data in our point cloud renderer for the requried padding. (not a big deal, but we should be safe and never write "random" data to the gpu unless we think the perf is worth the risks)
Checklist