-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add radius boost for depth clouds on outline #1713
Conversation
@ picture: you could have clicked them to make it more obvious 😄. But they are way too subtle now in too many cases (or is our background "wrong" ;)) :/. We need to find a better compromise |
44cffaa
to
d1e3dee
Compare
dbd865e
to
7a81a40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still unhappy about the uniform buffer/binding groups here. But not a hill to die on! Looking good otherwise, the renames and cleanups are appreciated!
"depth_cloud_bg".into(), | ||
create_and_fill_uniform_buffer( | ||
ctx, | ||
"PointCloudDrawData::DrawDataUniformBuffer".into(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started naming those by their field names and I think that's better practice than what we had before. I.e it would be DepthCloudDrawInstance::bind_group_opaque
here. Not consistent across everywhere though, jury is still out on this ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are in a better position to take a rename-pass over all of re_renderer
Normal point clouds:
![point-outline](https://user-images.githubusercontent.com/1148717/227892438-9e7931fd-676d-48d4-91d3-247b94a6e07b.gif)
Depth cloud point clouds:
![depth-cloud-outline](https://user-images.githubusercontent.com/1148717/227892469-16fef577-236b-4b57-b496-201e0ae02e1f.gif)
(looks carefully - the outlines have almost the same color as the background)
Checklist