Work around https://github.com/sebcrozet/instant/issues/49 #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
emilk
approved these changes
May 12, 2023
crates/re_log_types/src/time.rs
Outdated
Comment on lines
10
to
15
| // NOTE: Even though `instant` should work on wasm, `elapsed` is broken. | ||
| // See: https://github.com/sebcrozet/instant/issues/49 | ||
| // We would like to switch to `web-time`, but that's broken in a different way | ||
| // See issues in: https://github.com/rerun-io/rerun/pull/2093 | ||
| // | ||
| // So we implement what elapsed is supposed to do ourselves. |
There was a problem hiding this comment.
nit: this is a comment about the implementation and so should be within the function, not outside it
There was a problem hiding this comment.
Ahh; good call. I had started with two separate implementations so this made more sense, but will move into the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though
instantshould work on wasm,elapsedis broken. See:SystemTime::elapsed()is broken sebcrozet/instant#49We would like to switch to
web-time, but that's broken in a different way. See issues in:Fortunately elapsed isn't all that magical, so this is a good enough stop-gap for the time being.
Checklist
PR Build Summary: https://build.rerun.io/pr/2094