Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SystemTime::elapsed() is broken #49

Closed
justinlovinger opened this issue Aug 26, 2022 · 4 comments
Closed

SystemTime::elapsed() is broken #49

justinlovinger opened this issue Aug 26, 2022 · 4 comments

Comments

@justinlovinger
Copy link

self.duration_since(SystemTime::now()), https://github.com/sebcrozet/instant/blob/master/src/wasm.rs#L202, should be Self::now().duration_since(*self), like Instant.

@FrankReh
Copy link

@sebcrozet Would you accept a PR for this? This was introduced in PR #42. The std implementation for SystemTime::elapsed is also like @justinlovinger points out: https://github.com/rust-lang/rust/blob/109cccbe4f345c0f0785ce860788580c3e2a29f5/library/std/src/time.rs#L554-L556

@MingweiSamuel
Copy link

Wow this crate is so amazingly busted

@sebcrozet
Copy link
Owner

This is now fixed in version 0.1.13.
I have now marked the crate as unmaintained in the readme and cargo badge.

@MingweiSamuel
Copy link

Oh nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants