Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve styling of demo header #3022

Merged
merged 11 commits into from Aug 21, 2023
Merged

Improve styling of demo header #3022

merged 11 commits into from Aug 21, 2023

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Aug 17, 2023 •
edited by github-actions bot

What

Fixes #2732
Fixes #2856

Can be tested at https://demo.rerun.io/pr/3022

Checklist

@jprochazk jprochazk added 🕸️ web regarding running the viewer in a browser ui concerns graphical user interface labels Aug 17, 2023
martenbjork
martenbjork requested changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@martenbjork martenbjork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Added some tiny comments, but overall this looks great!

scripts/ci/demo_assets/static/index.css Outdated Show resolved Hide resolved
scripts/ci/demo_assets/static/index.css Outdated Show resolved Hide resolved
jprochazk and others added 2 commits August 21, 2023 11:07
martenbjork
martenbjork approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@martenbjork martenbjork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4b3aef55-8d91-445b-b0ac-6dea92d2ff15_text

@jprochazk jprochazk merged commit 76a4444 into main Aug 21, 2023
26 checks passed
@jprochazk jprochazk deleted the jan/demo-header-css branch August 21, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martenbjork martenbjork martenbjork approved these changes

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
ui concerns graphical user interface 🕸️ web regarding running the viewer in a browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable text selection in demo HTML header Improve styling of demo header
3 participants
@jprochazk @martenbjork @emilk