Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable text selection in demo HTML header #2856

Closed
Tracked by #2670
, #2732
...
martenbjork opened this issue Jul 28, 2023 · 1 comment · Fixed by #3022
Closed
Tracked by #2670
, #2732
...

Disable text selection in demo HTML header #2856

martenbjork opened this issue Jul 28, 2023 · 1 comment · Fixed by #3022
Assignees
@jprochazk
Labels
ui concerns graphical user interface 🕸️ web regarding running the viewer in a browser

Comments

@martenbjork
Copy link
Collaborator

martenbjork commented Jul 28, 2023 •
edited
Loading

Tiny issue: Sometimes when clicking things in the topbar, I accidentally move my cursor 1px and select (as in text selection) something in it. That's OK for websites, but in apps, it often makes the UI feel a bit...flaky. A simple user-select: none on all the items in the top bar would disable text selection there.

image
@martenbjork martenbjork mentioned this issue Jul 28, 2023
Open
25 tasks
@faizalmsdev
Copy link

Did anyone changed it?

@abey79 abey79 mentioned this issue Aug 7, 2023
Closed
9 tasks
@emilk emilk added 🕸️ web regarding running the viewer in a browser ui concerns graphical user interface labels Aug 8, 2023
@jprochazk jprochazk mentioned this issue Aug 17, 2023
Merged
3 tasks
jprochazk added a commit that referenced this issue Aug 21, 2023
@jprochazk @martenbjork
Improve styling of demo header (#3022)
76a4444 
<!--
Open the PR up as a draft until you feel it is ready for a proper
review.

Do not make PR:s from your own `main` branch, as that makes it difficult
for reviewers to add their own fixes.

Add any improvements to the branch as new commits to make it easier for
reviewers to follow the progress. All commits will be squashed to a
single commit once the PR is merged into `main`.

Make sure you mention any issues that this PR closes in the description,
as well as any other related issues.

To get an auto-generated PR description you can put "copilot:summary" or
"copilot:walkthrough" anywhere.
-->

### What

Fixes #2732
Fixes #2856

Can be tested at https://demo.rerun.io/pr/3022

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3022) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3022)
- [Docs
preview](https://rerun.io/preview/pr%3Ajan%2Fdemo-header-css/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Ajan%2Fdemo-header-css/examples)

---------

Co-authored-by: Marten Bjork <marten@martenbjork.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jprochazk jprochazk

Labels
ui concerns graphical user interface 🕸️ web regarding running the viewer in a browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve styling of demo header rerun-io/rerun
4 participants
@martenbjork @emilk @jprochazk @faizalmsdev