Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: cargo rerun websocket-url #3160

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Bug fix: cargo rerun websocket-url #3160

merged 1 commit into from
Aug 31, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Aug 30, 2023 •
edited by github-actions bot
Loading

Broke in #3116

Tried to use tokio from a rayon thread, which doesn't work out-of-the-box. But the rayon use is unnecessary - each call to data_source.stream is non-blocking anyways.

Checklist

@emilk emilk added 🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md labels Aug 30, 2023
@emilk emilk merged commit f253ca7 into main Aug 31, 2023
28 checks passed
@emilk emilk deleted the emilk/tokio-fix branch August 31, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @teh-cmc