Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome Page refresh #3219

Merged
merged 8 commits into from Sep 7, 2023
Merged

Welcome Page refresh #3219

merged 8 commits into from Sep 7, 2023

Conversation

abey79
Copy link
Contributor

@abey79 abey79 commented Sep 5, 2023

What

This PR:

  • implements a refreshed, toned-down Welcome Page;
  • add the panel linking to the examples page;
  • make the UI responsive.

This is a PR train, #3191 must be reviewed/fixed/merged first.

Fixes:

image

Checklist

@abey79 abey79 added the ui concerns graphical user interface label Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Size changes

Name main 3219/merge Change
plots.rrd 184.32 kiB 194.56 kiB +5.56%

@abey79 abey79 changed the base branch from main to antoine/example-list September 5, 2023 15:42
@abey79 abey79 force-pushed the antoine/welcome-page-refresh branch from 9d08a12 to 429d8be Compare September 5, 2023 20:34
@martenbjork
Copy link
Collaborator

Heck yes! This is looking really good out of the box! Here are my notes:

  • The content on the welcome screen should be vertically centered. It makes it feel less like a web page and more like app UI.
  • Tooltips should never display raw URLs. Just showing a URL to the user is bad UX, because it's a terrible explanation of what the button does. In this case, I think we can drop the button tooltips altogether — there is enough information already through the labels and icons.

Some margin tweaks: (Open image in new tab for hi-res)

Frame 31

@abey79
Copy link
Contributor Author

abey79 commented Sep 6, 2023

image

Skipping that for the right most column (looked better with the particular copy we have now). Hopefully this doesn't break some design rules :)

@abey79 abey79 force-pushed the antoine/welcome-page-refresh branch from 429d8be to 355969c Compare September 6, 2023 08:12
@martenbjork
Copy link
Collaborator

Hopefully this doesn't break some design rules :)

It does and I love it 😀 However, if Niko is still working on the copy and trying to get the lines to look right, this might create the impression that he has more space than he actually does?

crates/re_ui/src/icons.rs Outdated Show resolved Hide resolved
@abey79 abey79 force-pushed the antoine/welcome-page-refresh branch from 355969c to ba7544c Compare September 6, 2023 14:02
@nikolausWest
Copy link
Member

If it's still in play here is a prototype with my suggestions for updated copy: https://rerun-design-prototype-hg8ghy8s5-rerun.vercel.app/

If not I'll open a second PR once this lands

@abey79 abey79 force-pushed the antoine/welcome-page-refresh branch from 82d63e5 to 7ab32b8 Compare September 6, 2023 15:31
Base automatically changed from antoine/example-list to main September 6, 2023 15:34
@abey79 abey79 force-pushed the antoine/welcome-page-refresh branch from 7ab32b8 to 6f0c1f2 Compare September 6, 2023 15:42
@abey79
Copy link
Contributor Author

abey79 commented Sep 6, 2023

@nikolausWest I updated with your copy

@emilk emilk merged commit b1e163f into main Sep 7, 2023
19 checks passed
@emilk emilk deleted the antoine/welcome-page-refresh branch September 7, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants