Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Welcome Screen UI reactive #3043

Closed
abey79 opened this issue Aug 18, 2023 · 2 comments
Closed

Make Welcome Screen UI reactive #3043

abey79 opened this issue Aug 18, 2023 · 2 comments
Labels
ui concerns graphical user interface
Milestone
0.9 - Codegen, Ty...

Comments

@abey79
Copy link
Member

abey79 commented Aug 18, 2023 •
edited by emilk
Loading

Make the three columns of the Welcome Screen are not reactive, e.g. they remain horizontally arranged even on narrow screens. They should become vertically arranged on narrow screens.

It should even work on Mobile.
@abey79 abey79 added 😤 annoying Something in the UI / SDK is annoying to use 👀 needs triage This issue needs to be triaged by the Rerun team ui concerns graphical user interface and removed 😤 annoying Something in the UI / SDK is annoying to use 👀 needs triage This issue needs to be triaged by the Rerun team labels Aug 18, 2023
@abey79 abey79 added this to the 0.9 milestone Aug 18, 2023
@abey79 abey79 mentioned this issue Sep 5, 2023
Merged
3 tasks
emilk added a commit that referenced this issue Sep 7, 2023
@abey79 @emilk
Welcome Page refresh (#3219)
b1e163f 
### What

This PR:
- implements a refreshed, toned-down Welcome Page;
- add the panel linking  to the examples page;
- make the UI responsive.

This is a PR train, #3191 must be reviewed/fixed/merged first.

Fixes:
 - #3124
 - #3043

<img width="1608" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/28e68d38-2efa-41ab-96a0-2891bee59ea3">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3219) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3219)
- [Docs
preview](https://rerun.io/preview/53fef8c10871100e6aef8a2e49aff9d28e6cac6f/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/53fef8c10871100e6aef8a2e49aff9d28e6cac6f/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)

---------

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
@emilk
Copy link
Member

emilk commented Sep 8, 2023

What's left on this? Testing on Mobile?

@abey79
Copy link
Member Author

abey79 commented Sep 8, 2023

What's left on this? Testing on Mobile?

It should be fixed by #3219

@emilk emilk closed this as completed Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ui concerns graphical user interface
Projects
None yet
Milestone
0.9 - Codegen, Type Oriented Api
Development

No branches or pull requests
2 participants
@emilk @abey79