Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown support in TextDocument #3343

Merged
merged 10 commits into from
Sep 18, 2023
Merged

Markdown support in TextDocument #3343

merged 10 commits into from
Sep 18, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Sep 17, 2023

What

    rec.log(
        "markdown",
        &TextDocument::new(
            "# Hello\n\
             Markdown with `code`!\n\
             \n\
             A random image:\n\
             \n\
             ![A random image](https://picsum.photos/640/480)",
        )
        .with_media_type(MediaType::markdown()),
    )?;
image

This will let us add nice documentation explaining our examples.

Not yet supported

Checklist

@emilk emilk added enhancement New feature or request 📺 re_viewer affects re_viewer itself labels Sep 17, 2023
@emilk emilk marked this pull request as ready for review September 17, 2023 14:06
@teh-cmc teh-cmc self-requested a review September 18, 2023 06:55
Cargo.toml Outdated Show resolved Hide resolved
@emilk emilk merged commit de31501 into main Sep 18, 2023
26 checks passed
@emilk emilk deleted the emilk/markdown branch September 18, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants