Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Space View containers selectable and editable #4403

Merged
merged 3 commits into from Dec 1, 2023
Merged

Make Space View containers selectable and editable #4403

merged 3 commits into from Dec 1, 2023

Conversation

abey79
Copy link
Contributor

@abey79 abey79 commented Nov 30, 2023 •
edited by github-actions bot

What

Containers may now be selected and edited. For now, they can be transmuted into another container type, and grid containers have a setting for their column count.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested app.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@abey79
Make containers selectable and editable
8b6528a
@abey79
Merge branch 'main' into antoine/selectable-containers
9df611e 
# Conflicts:
#	crates/re_data_ui/src/item.rs
#	crates/re_time_panel/src/data_density_graph.rs
#	crates/re_viewer/src/ui/selection_panel.rs
#	crates/re_viewer_context/src/item.rs
#	crates/re_viewer_context/src/selection_state.rs
#	crates/re_viewport/src/viewport_blueprint.rs
@abey79 abey79 added ui concerns graphical user interface include in changelog labels Nov 30, 2023
@Wumpf Wumpf changed the title Make containers selectable and editable Make Space View containers selectable and editable Nov 30, 2023
@teh-cmc
Copy link
Member

teh-cmc commented Dec 1, 2023

Oooooh, that's sweet!

@teh-cmc teh-cmc self-requested a review December 1, 2023 08:10
teh-cmc
teh-cmc approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@teh-cmc teh-cmc left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat related: the fact that a space view for a TextDocument advertises itself as a Text Document is very confusing to me:
image

I was like "wait, why is this a TextDocument, clearly it's a view?! Ooooh, it's a Text<space>Document...".
Same thing with TextLog & Text Log.

@abey79
Copy link
Contributor Author

abey79 commented Dec 1, 2023

Somewhat related: the fact that a space view for a TextDocument advertises itself as a Text Document is very confusing to me: image

I was like "wait, why is this a TextDocument, clearly it's a view?! Ooooh, it's a Text<space>Document...". Same thing with TextLog & Text Log.

Well "Text Document" is the actual ID for these text Space Views, so that label made it to the UI, but since #4393 these can be changed without breaking blueprints and stuff, so yeah maybe we can make a pass on these actual labels. Will look into it.

@abey79
Merge branch 'main' into antoine/selectable-containers
2f30366 
# Conflicts:
#	Cargo.lock
#	crates/re_viewer/Cargo.toml
@abey79 abey79 merged commit 8881e21 into main Dec 1, 2023
40 checks passed
@abey79 abey79 deleted the antoine/selectable-containers branch December 1, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make containers selectable and inspectable in the Selection Panel
2 participants
@abey79 @teh-cmc