Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make containers selectable and inspectable in the Selection Panel #4162

Closed
Tracked by #4140
abey79 opened this issue Nov 7, 2023 · 0 comments · Fixed by #4403
Closed
Tracked by #4140

Make containers selectable and inspectable in the Selection Panel #4162

abey79 opened this issue Nov 7, 2023 · 0 comments · Fixed by #4403
Labels
ui concerns graphical user interface

Comments

@abey79
Copy link
Member

abey79 commented Nov 7, 2023

In particular, the Grid container needs to have some UI to select row/col count to bring parity with the (future) blueprint API

@abey79 abey79 changed the title Containers cannot be selected and inspected Make containers selectable and inspectable in the Selection Panel Nov 7, 2023
@abey79 abey79 added the ui concerns graphical user interface label Nov 7, 2023
abey79 added a commit that referenced this issue Dec 1, 2023
### What

Containers may now be selected and edited. For now, they can be
transmuted into another container type, and grid containers have a
setting for their column count.

- Closes #4162

<img width="1638" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/28c43f1e-d25f-4f70-b41d-50a3ac20f99a">

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4403) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4403)
- [Docs
preview](https://rerun.io/preview/2f30366bc1db4ffc0f5b3a4b3a7f9e8b2dffd7b4/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/2f30366bc1db4ffc0f5b3a4b3a7f9e8b2dffd7b4/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui concerns graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant