Fix incorrect bounding box calculation for camera view parts #4640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
approved these changes
Jan 3, 2024
| @@ -380,6 +380,9 @@ pub fn view_3d( | |||
| axis_length, | |||
| re_renderer::OutlineMaskPreference::NONE, | |||
| ); | |||
|
|
|||
| // If we are showing the axes for the space, then add the space origin to the bounding box. | |||
| state.scene_bbox.extend(glam::Vec3::ZERO); | |||
There was a problem hiding this comment.
I'm not sure about this. Maybe. The bounding box is used for auto-positioning of the camera, and I'm not sure users are always interested in seeing the bounding box axes (though, to be fair, they did turned them on).
When we have a 3D grid we definitely don't want to include it in the bounding box (since it is infinite) 😆
There was a problem hiding this comment.
My thought is that since origin axes are opt-in, if you've taken the action of enabling it, you should see it when you reset your view without needing to do significant zooming / panning to "search" for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
rr.Pinholecorrectly into account #4452The wrong transform was being used for the bounding box calculation.
Clarify the transform naming / construction.
Also include the origin when the origin axes are turned on.
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io