DisconnectedSpace now only applies to spatial space views
#4935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
📖 documentation
teh-cmc
approved these changes
Jan 29, 2024
crates/re_types/definitions/rerun/archetypes/disconnected_space.fbs
Outdated
Show resolved
Hide resolved
crates/re_types/definitions/rerun/components/disconnected_space.fbs
Outdated
Show resolved
Hide resolved
Wumpf
added a commit
that referenced
this pull request
Jan 30, 2024
### What * Fixes #4388 * this is the last piece 🥳 * Related to * #4935 * #4826 `SpaceInfo` used to be used to determine space connectivity, this is by now done by `SpatialTopology` Not a "pure" refactor: Slight changes in behavior * Adding a space view via the 'plus' top left uses the default-created list, not the now removed "all" list (which was poorly defined) * Similarly, suggestions for root now use the default-created list * adding entities via the add-ui no longer uses any kind of transform analysis (it relied on SpaceInfo) * Does not fix #4826 * .. since it still won't allow adding things that aren't visualizable at all ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/4937/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/4937/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/4937/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4937) - [Docs preview](https://rerun.io/preview/d27d81f094e026a2cecfd42ac25dc133d9ed26f6/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/d27d81f094e026a2cecfd42ac25dc133d9ed26f6/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR only addresses the documentation.
mainis actually in a slightly mixed state right now: Visualizability is already determined strictly withDisconnectedSpaceonly applying to spatial views, but we still have the legacySpaceInfoused in some places that applies this concept to everything. This will be removed in a a follow-up.Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io