Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisconnectSpace and TimeSeriesScalar #4465

Closed
rangsjo opened this issue Dec 11, 2023 · 3 comments · Fixed by #4935
Closed

DisconnectSpace and TimeSeriesScalar #4465

rangsjo opened this issue Dec 11, 2023 · 3 comments · Fixed by #4935
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself

Comments

@rangsjo
Copy link

rangsjo commented Dec 11, 2023

Describe the bug

rerun_example_disconnect_space does not work if TimeSeriesScalar is logged in python.

To Reproduce
Steps to reproduce the behavior:

  1. Run:

         # Slightly modified example code for disconnect space
         rr.init("rerun_example_disconnect_space", spawn=True)
    
         # These two points can be projected into the same space..
         rr.log("world/room1/point", rr.TimeSeriesScalar(0))
         rr.log("world/room2/point", rr.TimeSeriesScalar(1))
    
         # ..but this one lives in a completely separate space!
         rr.log("world/wormhole", rr.DisconnectedSpace())
         rr.log("world/wormhole/point", rr.TimeSeriesScalar(3))
    
  2. Look in the viewer for disconnected spaces.

Expected behavior

Two different spaces should be shown, but as stated, all signals are shown in one single space.

Screenshots

image

Desktop:

  • OS: ubuntu 22.04

Rerun version

rerun_py 0.10.1 [rustc 1.72.1 (d5c2e9c34 2023-09-13), LLVM 16.0.5] x86_64-unknown-linux-gnu release-0.10.1 e596e4e, built 2023-11-02T16:05:55Z

@rangsjo rangsjo added 👀 needs triage This issue needs to be triaged by the Rerun team 🪳 bug Something isn't working labels Dec 11, 2023
@Wumpf
Copy link
Member

Wumpf commented Dec 11, 2023

Thanks for filing the issue! This is indeed a bug the way DisconnectedSpace is defined. That said, itself is a workaround for not being able to specify what goes into which space view from code which is luckily about to change! (we've been saying that for a while now, but we're finally almost there 😅 )
We're also meanwhile want to make the way space view heuristic spawning works a bit more scalable and predictable. As part of that we concluded that DisconnectedSpace will likely be renamed to UndefinedTransform and only be applicable to 2D & 3D space views. I.e. it is regarded as a special spatial transform.

.. but as things are this is a bug as described.

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself 🟦 blueprint The data that defines our UI and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Dec 11, 2023
@Wumpf
Copy link
Member

Wumpf commented Dec 12, 2023

@emilk
Copy link
Member

emilk commented Jan 3, 2024

The plan is that setting up spaceviews should be done via the new blueprint API when this issue is done:

Wumpf added a commit that referenced this issue Jan 30, 2024
### What


* Part of #4388
* Fixes #4465

This PR only addresses the documentation. `main` is actually in a
slightly mixed state right now: Visualizability is already determined
strictly with `DisconnectedSpace` only applying to spatial views, but we
still have the legacy `SpaceInfo` used in some places that applies this
concept to everything. This will be removed in a a follow-up.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4935/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4935/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4935/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4935)
- [Docs
preview](https://rerun.io/preview/4eec4acd74c6d5a8f132bd8490895ae45e90aac7/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/4eec4acd74c6d5a8f132bd8490895ae45e90aac7/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants