Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setup_web script - pixi handles everything except wasm anyways already #5263

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Feb 23, 2024

What

pixi already handles binaryen. the rust target is ok to throw in as an instruction since it's fairly obvious

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md labels Feb 23, 2024
@Wumpf Wumpf requested a review from jprochazk February 23, 2024 12:39
…ually super fast when it's already installed
@Wumpf Wumpf merged commit 8bbf35a into main Feb 23, 2024
13 of 23 checks passed
@Wumpf Wumpf deleted the andreas/remove-setup_web branch February 23, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants