Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arrow libraries from download & build not being found in some cases #5366

Merged
merged 4 commits into from Mar 1, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 1, 2024

What

Apparently they don't always end up in /lib depending on how cmake was configured. This should fix this!

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added 🌊 C++ API C or C++ logging API include in changelog labels Mar 1, 2024
@Wumpf Wumpf requested a review from BirgerMoell March 1, 2024 10:06
@Wumpf Wumpf force-pushed the andreas/fix-arrow-libpath-issues branch from df6703e to 9f2fa0c Compare March 1, 2024 10:12
@02alexander 02alexander self-requested a review March 1, 2024 10:45
Copy link
Collaborator

@02alexander 02alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Fixed the issue for me.

@Wumpf Wumpf removed the request for review from BirgerMoell March 1, 2024 10:51
@Wumpf Wumpf merged commit bf27199 into main Mar 1, 2024
36 checks passed
@Wumpf Wumpf deleted the andreas/fix-arrow-libpath-issues branch March 1, 2024 10:51
@Wumpf Wumpf added the 🪳 bug Something isn't working label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🌊 C++ API C or C++ logging API include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants