Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the remaining space views and name them consistently #5498

Merged
merged 2 commits into from Mar 14, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Mar 13, 2024

What

Just lots of boiler plate with some name changes.

Also split the apy.py file into a few sub-modules because it was getting large.

All SpaceViews now end in View.

  • Spatial2DView
  • Spatial3DView
  • BarChartView
  • TensorView
  • TextDocumentView
  • TextLogView
  • TimeSeriesView

Testing it out on the plots example:
image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@jleibs jleibs added 🟦 blueprint The data that defines our UI 🐍 Python API Python logging API include in changelog labels Mar 13, 2024
@jleibs jleibs marked this pull request as ready for review March 13, 2024 20:15
@Wumpf Wumpf merged commit d77e025 into main Mar 14, 2024
34 of 40 checks passed
@Wumpf Wumpf deleted the jleibs/more_space_views branch March 14, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI include in changelog 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants