Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 Blueprint APIs for Python #4167

Closed
jleibs opened this issue Nov 7, 2023 · 2 comments
Closed

V2 Blueprint APIs for Python #4167

jleibs opened this issue Nov 7, 2023 · 2 comments
Assignees
@Wumpf @jleibs
Labels
🟦 blueprint The data that defines our UI 🐍 Python API Python logging API
Milestone
0.15

Comments

@jleibs
Copy link
Member

jleibs commented Nov 7, 2023 •
edited

We've got through a few conceptual iterations of the object-oriented APIs for blueprints.

See: https://github.com/rerun-io/rerun/blob/main/design/blueprint_store.md

Specific must-have features:

  • Support for hierarchy and layout
  • Single-construction blueprint objec
  • Blueprint passed to spawn/serve: rr.spawn(blueprint)

Related issues:
@jleibs jleibs added the 🟦 blueprint The data that defines our UI label Nov 7, 2023
@emilk emilk mentioned this issue Jan 3, 2024
Closed
@jleibs jleibs self-assigned this Jan 5, 2024
@nikolausWest nikolausWest added this to the Triage milestone Jan 30, 2024
@rishabh-slamcore
Copy link
Contributor

Voting to bring this issue to fore-front 👋

@Wumpf Wumpf modified the milestones: Triage, 0.15 Feb 26, 2024
@Wumpf Wumpf changed the title V2 Blueprint APIs V2 Blueprint APIs for Python Feb 26, 2024
@Wumpf Wumpf added the 🐍 Python API Python logging API label Feb 26, 2024
@jleibs jleibs mentioned this issue Feb 26, 2024
Closed
@Wumpf Wumpf self-assigned this Feb 29, 2024
@Wumpf Wumpf mentioned this issue Mar 1, 2024
Merged
5 tasks
Wumpf added a commit that referenced this issue Mar 4, 2024
@Wumpf
Uuid & IncludedSpaceView types are now serializable in python (#5372
236599f 
)

### What

* part of #4167

Steps towards serializable `ViewportBlueprint`. Adjusted structure a
bit: it used to be `IncludedSpaceViews` (plural) it's now
`IncludedSpaceView` (singular) and we store a component array on the
`ViewportBlueprint archetype.
Also, uuid needed some extra love on codegen as well.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5372/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5372/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5372/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5372)
- [Docs
preview](https://rerun.io/preview/67d77ed6fb8d0bcfa952dc6c3d300b713eb6ef77/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/67d77ed6fb8d0bcfa952dc6c3d300b713eb6ef77/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
@Wumpf Wumpf mentioned this issue Mar 4, 2024
Merged
5 tasks
Wumpf added a commit that referenced this issue Mar 5, 2024
@Wumpf
Python serializable ViewportBlueprint (#5385)
df7f46f 
### What

* direct followup to #5372
* part of #4167

--

* necessary massaging to get the rest of `ViewportBlueprint` to
serialize out of python
* finished up related unit test
* remove `ViewportLayout`
* unify blueprint component write helpers a bit


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5385/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5385/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5385/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5385)
- [Docs
preview](https://rerun.io/preview/a5f40715a5006839a0bebdacb87485bb5c349d4d/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/a5f40715a5006839a0bebdacb87485bb5c349d4d/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
@Wumpf Wumpf mentioned this issue Mar 5, 2024
Merged
5 tasks
jleibs added a commit that referenced this issue Mar 5, 2024
@Wumpf @jleibs
SpaceViewBlueprint is now python serializable (#5401)
203730d 
### What

Plus the usual amount of plumbing, following overall similar patterns
than the previous PRs in this area

* Sister PR to #5390
* Part of #4167

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5401/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5401/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5401/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5401)
- [Docs
preview](https://rerun.io/preview/4095985db6d11b3625e845b512983983c0bbea7a/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/4095985db6d11b3625e845b512983983c0bbea7a/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

---------

Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
@jleibs
Copy link
Member Author

jleibs commented Mar 15, 2024

Done in:

@jleibs jleibs closed this as completed Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

@jleibs jleibs

Labels
🟦 blueprint The data that defines our UI 🐍 Python API Python logging API
Projects
None yet
Milestone
0.15
Development

No branches or pull requests
4 participants
@Wumpf @nikolausWest @jleibs @rishabh-slamcore