-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update copy on welcome screen #5778
Conversation
@@ -40,9 +40,9 @@ pub(super) fn welcome_section_ui(ui: &mut egui::Ui) { | |||
ui.add_space(4.0); | |||
}; | |||
|
|||
bullet_text(ui, "Log with the Rerun SDK in C++, Python, or Rust"); | |||
bullet_text(ui, "Log data with the Rerun SDK in Python, C++, or Rust"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be consistent with the order of supported languages, and I believe that order should be lexicographical.
If you strongly disagree, then please change it everywhere in this repository and on landing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I agree they need to be consistent everywhere but sure thing. I think they should be ordered as Python, C++, Rust for marketing reasons since that is the order of popularity / usage. I added a commit that does this change to the other places I found it in this repo and here is the pr for landing: https://github.com/rerun-io/landing/pull/782
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can find more places to change by searching with the regex C\+\+.*\n?.*Python
Some of it is code-genned somewhere in crates/re_types_builder/src/codegen/docs/mod.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I give up
Second attempt at #5778 ### What ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [rerun.io/viewer](https://rerun.io/viewer/pr/5811) * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5811?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5811?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5811) - [Docs preview](https://rerun.io/preview/b5c7f424890c4cb71b9198e46718839da11fdef0/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/b5c7f424890c4cb71b9198e46718839da11fdef0/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
Second attempt at #5778 ### What ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [rerun.io/viewer](https://rerun.io/viewer/pr/5811) * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5811?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5811?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5811) - [Docs preview](https://rerun.io/preview/b5c7f424890c4cb71b9198e46718839da11fdef0/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/b5c7f424890c4cb71b9198e46718839da11fdef0/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
What
⬆️
![Screenshot 2024-04-04 at 22 13 54](https://private-user-images.githubusercontent.com/2624717/319760446-55e077a0-41cf-4322-8708-2f3d54fd4c27.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU3MDEwNjcsIm5iZiI6MTcyNTcwMDc2NywicGF0aCI6Ii8yNjI0NzE3LzMxOTc2MDQ0Ni01NWUwNzdhMC00MWNmLTQzMjItODcwOC0yZjNkNTRmZDRjMjcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MDdUMDkxOTI3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Y2FjZWNiMmY1N2Q0MWE3YTg0YTc1OTQ3Nzc2MDI3ZTQxNWY5YmUxOWQ1YzdjZWRkMjAzZWM4NjZkZjkzMmFlZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.-y6ngI1oApo6D0C1ksTF7BUQvWKQ-geAIUkpvb3B6OE)
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewer