Update copy on welcome screen #5778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolausWest
added
ui
emilk
requested changes
Apr 4, 2024
| @@ -40,9 +40,9 @@ pub(super) fn welcome_section_ui(ui: &mut egui::Ui) { | |||
| ui.add_space(4.0); | |||
| }; | |||
|
|
|||
| bullet_text(ui, "Log with the Rerun SDK in C++, Python, or Rust"); | |||
| bullet_text(ui, "Log data with the Rerun SDK in Python, C++, or Rust"); | |||
There was a problem hiding this comment.
I think we should be consistent with the order of supported languages, and I believe that order should be lexicographical.
If you strongly disagree, then please change it everywhere in this repository and on landing
There was a problem hiding this comment.
I'm not sure I agree they need to be consistent everywhere but sure thing. I think they should be ordered as Python, C++, Rust for marketing reasons since that is the order of popularity / usage. I added a commit that does this change to the other places I found it in this repo and here is the pr for landing: https://github.com/rerun-io/landing/pull/782
There was a problem hiding this comment.
You can find more places to change by searching with the regex C\+\+.*\n?.*Python
Some of it is code-genned somewhere in crates/re_types_builder/src/codegen/docs/mod.rs
jleibs
added a commit
that referenced
this pull request
Apr 5, 2024
Second attempt at #5778 ### What ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [rerun.io/viewer](https://rerun.io/viewer/pr/5811) * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5811?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5811?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5811) - [Docs preview](https://rerun.io/preview/b5c7f424890c4cb71b9198e46718839da11fdef0/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/b5c7f424890c4cb71b9198e46718839da11fdef0/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
jleibs
added a commit
that referenced
this pull request
Apr 5, 2024
Second attempt at #5778 ### What ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [rerun.io/viewer](https://rerun.io/viewer/pr/5811) * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5811?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5811?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5811) - [Docs preview](https://rerun.io/preview/b5c7f424890c4cb71b9198e46718839da11fdef0/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/b5c7f424890c4cb71b9198e46718839da11fdef0/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
⬆️
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewer