Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Scale3D/Transform3D/TranslationRotationScale3D datatypes, remove Transform3D component #7000

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jul 25, 2024

What

Removes

  • Scale3D datatypes
  • Transform3D datatype
  • TranslationRotationScale3D datatype
  • Transform3D component

compatibility considerations were already done all in previous PRs. For some of these there's utilities to make actual use similar to before.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added do-not-merge Do not merge this PR 🍏 primitives Relating to Rerun primitives include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages labels Jul 25, 2024
Copy link

github-actions bot commented Jul 25, 2024

Deployed docs

Commit Link
ab121bb https://landing-a4wow094g-rerun.vercel.app/docs

@Wumpf Wumpf marked this pull request as draft July 26, 2024 13:35
@Wumpf Wumpf force-pushed the andreas/remove-old-transform-component branch from 159915c to c007b46 Compare July 30, 2024 10:43
@Wumpf Wumpf changed the base branch from andreas/outoftreetransform-component to andreas/introduce-leaf-transform3d July 30, 2024 10:44
@Wumpf Wumpf marked this pull request as ready for review July 30, 2024 10:44
@Wumpf Wumpf force-pushed the andreas/remove-old-transform-component branch from c007b46 to 8beb0e5 Compare July 30, 2024 12:44
Base automatically changed from andreas/introduce-leaf-transform3d to main July 31, 2024 16:41
@Wumpf Wumpf removed the do-not-merge Do not merge this PR label Jul 31, 2024
@Wumpf Wumpf force-pushed the andreas/remove-old-transform-component branch from 8beb0e5 to ab121bb Compare July 31, 2024 16:42
@Wumpf Wumpf merged commit aa17ab4 into main Jul 31, 2024
40 checks passed
@Wumpf Wumpf deleted the andreas/remove-old-transform-component branch July 31, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages 🍏 primitives Relating to Rerun primitives
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant